Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner): removed external input from behavior_velocity #3407

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Apr 14, 2023

Description

Related links

launcher PR: autowarefoundation/autoware_launch#296

Tests performed

In Psim

Interface changes

Removed deprecated topic ~/input/external_{intersection, crosswalk, traffic_light}_status.

Effects on system behavior

No influence on current system configuration

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Apr 14, 2023
@soblin soblin marked this pull request as ready for review April 14, 2023 06:06
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bdbde10) 12.22% compared to head (6367111) 12.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3407   +/-   ##
=======================================
  Coverage   12.22%   12.23%           
=======================================
  Files        1380     1380           
  Lines       96890    96830   -60     
  Branches    28017    27984   -33     
=======================================
  Hits        11847    11847           
+ Misses      72487    72425   -62     
- Partials    12556    12558    +2     
Flag Coverage Δ *Carryforward flag
differential 3.64% <0.00%> (?)
total 12.23% <ø> (+<0.01%) ⬆️ Carriedforward from bdbde10

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/behavior_velocity_planner/planner_data.hpp 0.00% <ø> (ø)
...anner/include/scene_module/traffic_light/scene.hpp 0.00% <ø> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.46% <ø> (+0.04%) ⬆️
...ity_planner/src/scene_module/crosswalk/manager.cpp 0.00% <ø> (ø)
...ner/src/scene_module/crosswalk/scene_crosswalk.cpp 0.00% <ø> (ø)
..._planner/src/scene_module/intersection/manager.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)
...planner/src/scene_module/traffic_light/manager.cpp 0.00% <ø> (ø)
...y_planner/src/scene_module/traffic_light/scene.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soblin soblin merged commit d73c3ae into autowarefoundation:main Apr 14, 2023
@soblin soblin deleted the refactor/remove-external-input branch April 14, 2023 06:17
soblin added a commit to soblin/autoware.universe that referenced this pull request May 7, 2023
…vior_velocity (autowarefoundation#3407)

removed external input from behavior_velocity

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants