-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(planning_validator): add interface test #3406
test(planning_validator): add interface test #3406
Conversation
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
This reverts commit 6cd13f8. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
`if (a && b, c)` is the same as `if (c)` not `if (a && b && c)` !! Signed-off-by: Vincent Richard <vincent.francois.richard@gmail.com>
…dation#3245) * refactor(crop_box_filter): remove always true condition tf_input_frame_ can't be empty in crop box filter. Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> * style(pre-commit): autofix --------- Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…oundation#3306) * feat(pointcloud_preprocessor): add data layout check utils When input cloud data layout is compatible filters can copy data faster. Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> * style(pre-commit): autofix * add "name" field check cleaning Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> --------- Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3406 +/- ##
==========================================
+ Coverage 12.23% 12.25% +0.02%
==========================================
Files 1380 1381 +1
Lines 96845 96737 -108
Branches 27990 27913 -77
==========================================
+ Hits 11845 11857 +12
+ Misses 72443 72304 -139
- Partials 12557 12576 +19
*This pull request uses carry forward flags. Click here to find out more.
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@@ -1,4 +1,4 @@ | |||
cmake_minimum_required(VERSION 3.14) | |||
cmake_minimum_required(VERSION 3.22) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Memo: the build failed in old version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked well
Description
Objective:
There have been frequent issues where planning nodes stop functioning when they receive special routes (will referr as "exceptional routes"). In this PR, created and implemented tests to ensure that nodes do not stop when they receive exceptional routes as input.
Method:
These verification points are categorized into the following two groups:
Related links
Tests performed
Tests performed
please run the following command and verify that it produces the expected output:
If the following output is returned, then the changes in this pull request have passed all tests:
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.