Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(planning_validator): add interface test #3406

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Apr 14, 2023

Description

Objective:

There have been frequent issues where planning nodes stop functioning when they receive special routes (will referr as "exceptional routes"). In this PR, created and implemented tests to ensure that nodes do not stop when they receive exceptional routes as input.

Method:

  1. For each node, publish the necessary topics for the node to function from test_node_.
  2. Verify that the node does not stop functioning.
  3. Confirm that the final output topic of the node can be subscribed to by test_node_.

These verification points are categorized into the following two groups:

  1. Confirm that the necessary topics are output from test_node_ and the node is functioning properly.
  • Use simple routes or routes necessary for the node to function properly as inputs to verify normal operation.
  1. After confirming the above operation, output exceptional routes (empty routes, single point routes, routes with duplicate points, etc.) from test_node_ and ensure that the node does not stop functioning.
  • When using exceptional routes as input, there is no need to publish the final output. It is sufficient to confirm that the node does not stop functioning.

Related links

Tests performed

Tests performed

please run the following command and verify that it produces the expected output:

colcon test --event-handlers console_cohesion+ --packages-select planning_validator

If the following output is returned, then the changes in this pull request have passed all tests:

100% tests passed, 0 tests failed out of 5

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

kyoichi-sugahara and others added 30 commits March 7, 2023 17:58
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
This reverts commit 6cd13f8.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
satoshi-ota and others added 5 commits April 14, 2023 18:59
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
`if (a && b, c)` is the same as `if (c)` not `if (a && b && c)` !!

Signed-off-by: Vincent Richard <vincent.francois.richard@gmail.com>
…dation#3245)

* refactor(crop_box_filter): remove always true condition

tf_input_frame_ can't be empty in crop box filter.

Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…oundation#3306)

* feat(pointcloud_preprocessor): add data layout check utils

When input cloud data layout is compatible filters can copy data faster.

Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>

* style(pre-commit): autofix

* add "name" field check

cleaning

Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>

---------

Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: +0.02 🎉

Comparison is base (494ae1c) 12.23% compared to head (79d106c) 12.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3406      +/-   ##
==========================================
+ Coverage   12.23%   12.25%   +0.02%     
==========================================
  Files        1380     1381       +1     
  Lines       96845    96737     -108     
  Branches    27990    27913      -77     
==========================================
+ Hits        11845    11857      +12     
+ Misses      72443    72304     -139     
- Partials    12557    12576      +19     
Flag Coverage Δ *Carryforward flag
differential 46.42% <16.66%> (?)
total 12.24% <ø> (+0.01%) ⬆️ Carriedforward from 9933a32

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 0.12% <ø> (+<0.01%) ⬆️
...or/src/crop_box_filter/crop_box_filter_nodelet.cpp 0.00% <ø> (ø)
.../pointcloud_preprocessor/src/utility/utilities.cpp 0.00% <ø> (ø)
...est/src/test_planning_validator_node_interface.cpp 16.66% <16.66%> (ø)

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe removed the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Apr 14, 2023
@kyoichi-sugahara kyoichi-sugahara enabled auto-merge (squash) April 14, 2023 10:43
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.14)
cmake_minimum_required(VERSION 3.22)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Memo: the build failed in old version

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked well

@kyoichi-sugahara kyoichi-sugahara merged commit 7ff4ebc into autowarefoundation:main Apr 15, 2023
@kyoichi-sugahara kyoichi-sugahara deleted the test/planning_interface_test_planning_validator branch May 12, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants