Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): stop only when there is enough space to avoid #3055

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 11, 2023

Description

Previously, the vehicle stopped in front of the vehicle in not only Scenario A but B. However I think it is better that the avoidance module shonldn't insert stopping velocity, and obstacle stop/cruise planner should do it instead in Scenario B, because the avoidance module never execute avoidance maneuver. In this PR, I update behavior decision logic, and the vehicle stops only when there is enough space to avoid (Scenario A).

Scenario A Scenerio B
there is enough space to avoid YES (is_avoidanble = true) NO (is_avoidanble = false)
there is enough lateral margin NO (< lateral_passable_safety_buffer) NO (< lateral_passable_safety_buffer)
behavior stop in front of the target object NOT stop in front of the tqarget object
image image

Test perform

Scenario A

simplescreenrecorder-2023-03-12_14.24.44.mp4

Scenario B

simplescreenrecorder-2023-03-12_14.34.56.mp4

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 11, 2023
@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a23a4b) 11.92% compared to head (36fb444) 11.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3055   +/-   ##
=======================================
  Coverage   11.92%   11.92%           
=======================================
  Files        1334     1334           
  Lines       92928    92928           
  Branches    24729    24729           
=======================================
  Hits        11078    11078           
  Misses      70370    70370           
  Partials    11480    11480           
Flag Coverage Δ *Carryforward flag
differential 5.55% <0.00%> (?)
total 11.92% <ø> (+<0.01%) ⬆️ Carriedforward from 2a23a4b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@takayuki5168
Copy link
Contributor

Super cool!

@satoshi-ota satoshi-ota merged commit 9971be3 into autowarefoundation:main Mar 17, 2023
@satoshi-ota satoshi-ota deleted the fix/stop-only-when-avoidable branch March 17, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants