fix(avoidance): stop only when there is enough space to avoid #3055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the vehicle stopped in front of the vehicle in not only Scenario A but B. However I think it is better that the avoidance module shonldn't insert stopping velocity, and obstacle stop/cruise planner should do it instead in Scenario B, because the avoidance module never execute avoidance maneuver. In this PR, I update behavior decision logic, and the vehicle stops only when there is enough space to avoid (Scenario A).
is_avoidanble = true
)is_avoidanble = false
)lateral_passable_safety_buffer
)lateral_passable_safety_buffer
)Test perform
Scenario A
simplescreenrecorder-2023-03-12_14.24.44.mp4
Scenario B
simplescreenrecorder-2023-03-12_14.34.56.mp4
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.