-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lidar_centerpoint): add build only option for tensorrt engine #2677
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2677 +/- ##
==========================================
+ Coverage 11.93% 12.75% +0.81%
==========================================
Files 1320 1218 -102
Lines 91849 85981 -5868
Branches 24469 24469
==========================================
Hits 10965 10965
+ Misses 69523 63655 -5868
Partials 11361 11361
*This pull request uses carry forward flags. Click here to find out more. see 102 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yukke42 <yukke42@users.noreply.github.com>
perception/lidar_centerpoint/launch/lidar_centerpoint.launch.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: yukke42 <yukke42@users.noreply.github.com>
Signed-off-by: yukke42 <yukke42@users.noreply.github.com>
Signed-off-by: yukke42 <yukke42@users.noreply.github.com>
I think this has to do with the destructor order due to the data relationship of some elements. If I add this, the problem goes away:
Log:
Additionally, there are some unused variables |
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
@knzo25 Thank you for your advise! I have fixed the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a typo, LGTM !
Checked the runtime of the engine generation and posterior loading
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@wep21 Cloud you check the updates? 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…utowarefoundation#2677) * feat(lidar_centerpoint): add build only option for tensorrt engine Signed-off-by: yukke42 <yukke42@users.noreply.github.com> * fix typo Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * style(pre-commit): autofix * chore: add description Signed-off-by: yukke42 <yukke42@users.noreply.github.com> * chore: shutdown node Signed-off-by: yukke42 <yukke42@users.noreply.github.com> * feat: use tensorrt_commom Signed-off-by: yukke42 <yukke42@users.noreply.github.com> * fix: resolve the crash when shutting down the node Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> * chore: fix typo Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: yukke42 <yukke42@users.noreply.github.com> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
* feat(lidar_centerpoint): add build only option for tensorrt engine (#2677) * feat(lidar_centerpoint): add build only option for tensorrt engine Signed-off-by: yukke42 <yukke42@users.noreply.github.com> * fix typo Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * style(pre-commit): autofix * chore: add description Signed-off-by: yukke42 <yukke42@users.noreply.github.com> * chore: shutdown node Signed-off-by: yukke42 <yukke42@users.noreply.github.com> * feat: use tensorrt_commom Signed-off-by: yukke42 <yukke42@users.noreply.github.com> * fix: resolve the crash when shutting down the node Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> * chore: fix typo Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: yukke42 <yukke42@users.noreply.github.com> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * fix(lidar_centerpoint): fix class (#3934) * fix(lidar_centerpoint): fix class Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> * feat(lidar_centerpoint): fix range in config for centerpoint Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> * feat(lidar_centerpoint): fix the ranges and voxel size Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> --------- Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> * Revert "fix: use centerpoint_tiny to centerpoint" This reverts commit efcf726. --------- Signed-off-by: yukke42 <yukke42@users.noreply.github.com> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com>
Signed-off-by: yukke42 yusuke.muramatsu@tier4.jp
Description
Add a new feature to build onnx files to tensorrt engine files without inference for CI/CD requirements.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.