-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_velocity_planner): output stop reason of traffic light whenever a stop point is inserted #2323
feat(behavior_velocity_planner): output stop reason of traffic light whenever a stop point is inserted #2323
Conversation
…whenever a stop point is inserted Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportBase: 10.48% // Head: 10.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2323 +/- ##
==========================================
- Coverage 10.48% 10.48% -0.01%
==========================================
Files 1249 1249
Lines 90888 90910 +22
Branches 20860 20870 +10
==========================================
Hits 9531 9531
- Misses 71229 71250 +21
- Partials 10128 10129 +1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…whenever a stop point is inserted (autowarefoundation#2323) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…whenever a stop point is inserted (backport autowarefoundation#2323) (#209) feat(behavior_velocity_planner): output stop reason of traffic light whenever a stop point is inserted (autowarefoundation#2323) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
…whenever a stop point is inserted (autowarefoundation#2323) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…whenever a stop point is inserted (autowarefoundation#2323) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
…whenever a stop point is inserted (autowarefoundation#2323) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Description
In the current implementation, when the car stops by the traffic light module and its stop reason is RTC, the
stop_reasons
of traffic light is not output.As other behavior modules, I changed that in cases like the above
stop_reasons
with emptystop_factor_points
is output.Review
1,
Comment out
default_enable_list."traffic_light"
in rtc_auto_mode_manager.param.yamlSet a route including stop lines for traffic lights
Confirm the stop_reason of traffic light is output
ros2 topic echo /planning/scenario_planning/status/stop_reasons|grep TrafficLight -A 11
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.