-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(map_based_prediction): fix too short predicted path #2305
fix(map_based_prediction): fix too short predicted path #2305
Conversation
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Besides bug fixes, by giving the parameter
|
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Codecov ReportBase: 10.50% // Head: 10.49% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2305 +/- ##
==========================================
- Coverage 10.50% 10.49% -0.02%
==========================================
Files 1248 1248
Lines 90581 90697 +116
Branches 20705 20705
==========================================
Hits 9516 9516
- Misses 70970 71086 +116
Partials 10095 10095
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your corrections! LGTM!
…dation#2305) * fix(map_based_prediction): fix too short predicted path Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix: remove unused variable Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * remove AddValidPath Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…dation#2305) * fix(map_based_prediction): fix too short predicted path Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix: remove unused variable Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * remove AddValidPath Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
…dation#2305) * fix(map_based_prediction): fix too short predicted path Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix: remove unused variable Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * remove AddValidPath Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Description
In map_based_pridiction, there are cases where the length of predicted_path of objects is extremely short.
https://user-images.githubusercontent.com/59680180/202166907-ccff8a81-b19c-4155-9971-f728806a0c0f.mp4
(arround 0:24)
This is because the
search_dist
forpossiblePaths()
is too short to sufficiently explore far lanes.I fixed this by adding a Frenet length of the current lane to
search_dist
.Note: this can cause increase in CPU consumption.
Related links
Tests performed
@ Planning simulator
https://user-images.githubusercontent.com/59680180/202167875-1d594bfb-de97-4a47-80ef-fa0ddc9e1489.mp4
https://user-images.githubusercontent.com/59680180/202167896-532a2378-336e-4f95-8a6b-e35e7ce7ae85.mp4
https://user-images.githubusercontent.com/59680180/202167926-d6334f30-9b57-4072-8e3d-a9502d5022a2.mp4
I also confirmed that the frequency of
/perception/object_recognition/objects
output by map_based_prediction does not drop significantly.Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.