Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (system_monitor) adding a node for CMOS battery monitoring #1989

Merged
merged 352 commits into from
Oct 20, 2022
Merged

feat: (system_monitor) adding a node for CMOS battery monitoring #1989

merged 352 commits into from
Oct 20, 2022

Conversation

nobuotakamasa
Copy link
Contributor

@nobuotakamasa nobuotakamasa commented Sep 29, 2022

Description

adding "system_monitor/ecu_monitor" node that monitors for CMOS battery health.
This PR is related to the following issue.
#1452

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

nobuotakamasa and others added 30 commits September 15, 2022 18:35
…/autoware.universe into feature_battery_monitoring
…/autoware.universe into feature_battery_monitoring
…/autoware.universe into feature_battery_monitoring
…/autoware.universe into feature_battery_monitoring
…/autoware.universe into feature_battery_monitoring
…/autoware.universe into feature_battery_monitoring
pre-commit-ci bot and others added 16 commits October 18, 2022 17:51
Signed-off-by: Nobuo TAKAMASA <nobuo.takamasa@tier4.jp>
…sa/autoware.universe into feature_battery_monitoring_2

Signed-off-by: Nobuo TAKAMASA <nobuo.takamasa@tier4.jp>
Signed-off-by: Nobuo TAKAMASA <nobuo.takamasa@tier4.jp>
Signed-off-by: Nobuo TAKAMASA <nobuo.takamasa@tier4.jp>
…sa/autoware.universe into feature_battery_monitoring_2

Signed-off-by: Nobuo TAKAMASA <nobuo.takamasa@tier4.jp>
Signed-off-by: Nobuo TAKAMASA <nobuo.takamasa@tier4.jp>
…sa/autoware.universe into feature_battery_monitoring_2
Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ito-san ito-san merged commit 29c3a2f into autowarefoundation:main Oct 20, 2022
@ito-san ito-san mentioned this pull request Oct 20, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.