-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pointcloud_preprocessor): separate targets for base class #1982
Conversation
@lchojnack Could you try this PR for #1009? I can also reproduce the error with following commands.
|
Codecov ReportBase: 10.40% // Head: 10.40% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1982 +/- ##
=======================================
Coverage 10.40% 10.40%
=======================================
Files 1159 1159
Lines 82172 82172
Branches 19290 19290
=======================================
Hits 8554 8554
Misses 64348 64348
Partials 9270 9270
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
fa66bd7
to
38ebd01
Compare
I try this PR but get this error Any idea @wep21 |
@wep21 I've tested the PR and it's working. I don't see the issue anymore. |
@lhakim85 Could you provide more details about your environment? (compiler, arm or amd64, etc) |
@mitsudome-r here the detail Setup B Both setup fail to compile with same error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works for me.
Ubuntu20.04
11th Gen Intel® Core™ i7-11800H
GPU RTX 2520
gcc 9.4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…refoundation#1982) Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
* fix(pointcloud_preprocessor): separate targets for base class (autowarefoundation#1982) Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix(pointcloud_preprocessor): add missed target dependency (autowarefoundation#2101) Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Signed-off-by: Kaan Colak <kcolak@leodrive.ai> * fix: remove un-existed file from cmake Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Kaan Çolak <kaancolak95@gmail.com>
…refoundation#1982) Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: scepter914 <scepter914@gmail.com>
* fix(pointcloud_preprocessor): separate targets for base class (autowarefoundation#1982) Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix(pointcloud_preprocessor): add missed target dependency (autowarefoundation#2101) Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Signed-off-by: Kaan Colak <kcolak@leodrive.ai> * fix: remove un-existed file from cmake Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Kaan Çolak <kaancolak95@gmail.com>
* fix(pointcloud_preprocessor): separate targets for base class (autowarefoundation#1982) Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix(pointcloud_preprocessor): add missed target dependency (autowarefoundation#2101) Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Signed-off-by: Kaan Colak <kcolak@leodrive.ai> * fix: remove un-existed file from cmake Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Kaan Çolak <kaancolak95@gmail.com>
Description
closes #1009
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.