feat(component_interface_utils): apply message change #1921
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
| { | ||
|
|
||
| template <class T1, class T2> | ||
| void copy(const T1 & src, T2 & dst) // NOLINT cpplint false positive |
There was a problem hiding this comment.
Could you write the error message here?
There was a problem hiding this comment.
Is it like this 1c5b53b? The error message is:
Add #include <algorithm> for copy [build/include_what_you_use] [4]
There was a problem hiding this comment.
In addition, this also causes false positives in execution.
component_interface_utils::status::copy(a, b); // cpplint requires algorithm header
There was a problem hiding this comment.
Ah, no. I just wanted to know this one. Thanks!
Add #include <algorithm> for copy [build/include_what_you_use] [4]
There was a problem hiding this comment.
In addition, this also causes false positives in execution.
Maybe related? cpplint/cpplint#200
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Codecov ReportBase: 10.33% // Head: 10.33% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1921 +/- ##
=======================================
Coverage 10.33% 10.33%
=======================================
Files 1147 1147
Lines 81613 81613
Branches 19048 19048
=======================================
Hits 8434 8434
Misses 64184 64184
Partials 8995 8995
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
isamu-takagi
deleted the
feature/ad-api/update-message-component-inteface-util
branch
…tion#1921) * feat(component_interface_utils): apply message change Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add error category Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…tion#1921) * feat(component_interface_utils): apply message change Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add error category Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…tion#1921) * feat(component_interface_utils): apply message change Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add error category Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…tion#1921) * feat(component_interface_utils): apply message change Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add error category Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp
Description
Apply message change #1897 to component_interface_utils package.
Use template functions for response status.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.