-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(velodyne_monitor): add 20 to temp_hot_*** #1744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5af993a
to
18ec6e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #1744 +/- ##
=======================================
Coverage 10.29% 10.29%
=======================================
Files 1202 1202
Lines 86711 86711
Branches 20054 20054
=======================================
Hits 8930 8930
Misses 68485 68485
Partials 9296 9296
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fix(velodyne_monitor): add 20 to temp_hot_***
… (#101) fix(velodyne_monitor): add 20 to temp_hot_***
Can you please provide the background of the 20 degree higher setting in the description section of this PR? |
@yn-mrse I fixed PR comment to explain the reason. |
fix(velodyne_monitor): add 20 to temp_hot_***
fix(velodyne_monitor): add 20 to temp_hot_***
fix(velodyne_monitor): add 20 to temp_hot_***
fix(velodyne_monitor): add 20 to temp_hot_***
fix(velodyne_monitor): add 20 to temp_hot_***
fix(velodyne_monitor): add 20 to temp_hot_***
…m awf/autoware.universe (#152) * fix(velodyne monitor): fix warning and error threshold of hot temperature (#1623) * fix(velodyne_monitor): fix warning and error threshold of hot temperature * doc: update README * doc: fix typo * doc: update README * feat: add config file for each model Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * Update Readme.md * Update Readme.md * fix: typo Signed-off-by: h-ohta <hiroki.ota@tier4.jp> Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * fix(velodyne_monitor): add temp_hot_*** to 20 (autowarefoundation#1744) fix(velodyne_monitor): add 20 to temp_hot_*** Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
fix(velodyne_monitor): add 20 to temp_hot_***
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.