Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(velodyne_monitor): add 20 to temp_hot_*** #1744

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Aug 31, 2022

Description

  • add 20 to temp_hot_*** to set back previous value.This is because VLP-32C has higher temperature than operational while working in the indoor enivronment.
  • update README

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta requested a review from ito-san as a code owner August 31, 2022 07:50
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta enabled auto-merge (squash) August 31, 2022 07:59
@h-ohta h-ohta changed the title fix(velodyne_monitor): add temp_hot_*** to 20 fix(velodyne_monitor): add 20 to temp_hot_*** Aug 31, 2022
Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1744 (18ec6e3) into main (4b8cf17) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1744   +/-   ##
=======================================
  Coverage   10.29%   10.29%           
=======================================
  Files        1202     1202           
  Lines       86711    86711           
  Branches    20054    20054           
=======================================
  Hits         8930     8930           
  Misses      68485    68485           
  Partials     9296     9296           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.28% <0.00%> (ø) Carriedforward from 4b8cf17

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../src/goal_pose_visualizer/goal_pose_visualizer.cpp 0.00% <0.00%> (ø)
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <0.00%> (ø)
...sion_planner_lanelet2/mission_planner_lanelet2.cpp 0.00% <0.00%> (ø)
...src/mission_planner_lanelet2/utility_functions.cpp 0.00% <0.00%> (ø)
...src/mission_planner_lanelet2/utility_functions.hpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@h-ohta h-ohta merged commit 8a097d8 into main Aug 31, 2022
@h-ohta h-ohta deleted the fix/velodyne_temperature branch August 31, 2022 09:06
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Aug 31, 2022
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Aug 31, 2022
… (#101)

fix(velodyne_monitor): add 20 to temp_hot_***
@yn-mrse
Copy link
Contributor

yn-mrse commented Aug 31, 2022

Can you please provide the background of the 20 degree higher setting in the description section of this PR?
It is preferable to include this information in the README if possible, but at a minimum, the description in the PR will ensure traceability.

@h-ohta
Copy link
Contributor Author

h-ohta commented Aug 31, 2022

@yn-mrse I fixed PR comment to explain the reason.

boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2022
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
s-azumi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
…m awf/autoware.universe (#152)

* fix(velodyne monitor): fix warning and error threshold of hot temperature (#1623)

* fix(velodyne_monitor): fix warning and error threshold of hot temperature

* doc: update README

* doc: fix typo

* doc: update README

* feat: add config file for each model

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Update Readme.md

* Update Readme.md

* fix: typo

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* fix(velodyne_monitor): add temp_hot_*** to 20 (autowarefoundation#1744)

fix(velodyne_monitor): add 20 to temp_hot_***

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants