-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): fix stop path for pull_over #1742
fix(behavior_path_planner): fix stop path for pull_over #1742
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1742 +/- ##
==========================================
- Coverage 10.38% 10.36% -0.02%
==========================================
Files 1211 1211
Lines 87406 87533 +127
Branches 20282 20373 +91
==========================================
Hits 9075 9075
- Misses 68849 68972 +123
- Partials 9482 9486 +4
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
485b0dd
to
257bb02
Compare
@rej55
|
planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…_over_module.cpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
663eb3d
to
7e85b3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…dation#1742) * fix(behavior_path_planner): fix stop path for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use previous stop path when is has been generated Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
…dation#1742) * fix(behavior_path_planner): fix stop path for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use previous stop path when is has been generated Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
…dation#1742) * fix(behavior_path_planner): fix stop path for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use previous stop path when is has been generated Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
…dation#1742) * fix(behavior_path_planner): fix stop path for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use previous stop path when is has been generated Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
…dation#1742) * fix(behavior_path_planner): fix stop path for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use previous stop path when is has been generated Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
…dation#1742) * fix(behavior_path_planner): fix stop path for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use previous stop path when is has been generated Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
…dation#1742) * fix(behavior_path_planner): fix stop path for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use previous stop path when is has been generated Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
…dation#1742) * fix(behavior_path_planner): fix stop path for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use previous stop path when is has been generated Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
…dation#1742) * fix(behavior_path_planner): fix stop path for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use previous stop path when is has been generated Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
…dation#1742) * fix(behavior_path_planner): fix stop path for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use previous stop path when is has been generated Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Description
In pull_over, ego-vehicle stops in the road lane when there is no available parking space.
However, it may not be able to stop completely at low speeds.
(
getStopPath
sets deceleration velocity forward, but resample inserts the current speed forward.)In this PR, when the current velocity is less than 1.0m/s, set 0.0m/s to path and make ego stop immediately.I changed the algorism to one that compares the previous safety state like
before
2022-08-31-12-28-51.mp4
after
pull_over_stop-2022-08-31_16.02.34_trim.mp4
Related links
Tests performed
psim
(TIER IV internal scenario tests https://evaluation.tier4.jp/evaluation/reports/faf22a21-a6aa-58c7-b53c-d8c293a58c59?project_id=prd_jt)
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.