Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix stop path for pull_over #1742

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 31, 2022

Description

In pull_over, ego-vehicle stops in the road lane when there is no available parking space.
However, it may not be able to stop completely at low speeds.
(getStopPath sets deceleration velocity forward, but resample inserts the current speed forward.)
In this PR, when the current velocity is less than 1.0m/s, set 0.0m/s to path and make ego stop immediately.
I changed the algorism to one that compares the previous safety state like

  • safe: generate pull_out_path
  • safe -> not_safe: generate new stop_path
  • not_safe -> not_safe: use previous stop_path

before

2022-08-31-12-28-51.mp4

after

pull_over_stop-2022-08-31_16.02.34_trim.mp4

Related links

Tests performed

psim
(TIER IV internal scenario tests https://evaluation.tier4.jp/evaluation/reports/faf22a21-a6aa-58c7-b53c-d8c293a58c59?project_id=prd_jt)

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1742 (7e85b3f) into main (fd0d776) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1742      +/-   ##
==========================================
- Coverage   10.38%   10.36%   -0.02%     
==========================================
  Files        1211     1211              
  Lines       87406    87533     +127     
  Branches    20282    20373      +91     
==========================================
  Hits         9075     9075              
- Misses      68849    68972     +123     
- Partials     9482     9486       +4     
Flag Coverage Δ *Carryforward flag
differential 1.26% <0.00%> (?)
total 10.36% <0.00%> (ø) Carriedforward from fd0d776

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/pull_over/pull_over_module.hpp 0.00% <ø> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kosuke55
Copy link
Contributor Author

kosuke55 commented Sep 2, 2022

@rej55
Thank you for your advice.
I changed the algorism to one that compares the previous safety state like

  • safe: generate pull_out_path
  • safe -> not_safe: generate new stop_path
  • not_safe -> not_safe: use previous stop_path

@rej55 rej55 changed the title fix(behavior_path_planner) fix stop path for pull_over fix(behavior_path_planner): fix stop path for pull_over Sep 2, 2022
kosuke55 and others added 3 commits September 2, 2022 15:03
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…_over_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 merged commit 8c2080c into autowarefoundation:main Sep 2, 2022
@kosuke55 kosuke55 deleted the fix/stop_path_for_pull_over branch September 2, 2022 07:47
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…dation#1742)

* fix(behavior_path_planner): fix stop path for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use previous stop path when is has been generated

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…dation#1742)

* fix(behavior_path_planner): fix stop path for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use previous stop path when is has been generated

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…dation#1742)

* fix(behavior_path_planner): fix stop path for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use previous stop path when is has been generated

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2022
…dation#1742)

* fix(behavior_path_planner): fix stop path for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use previous stop path when is has been generated

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 14, 2022
…dation#1742)

* fix(behavior_path_planner): fix stop path for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use previous stop path when is has been generated

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…dation#1742)

* fix(behavior_path_planner): fix stop path for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use previous stop path when is has been generated

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 18, 2022
…dation#1742)

* fix(behavior_path_planner): fix stop path for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use previous stop path when is has been generated

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…dation#1742)

* fix(behavior_path_planner): fix stop path for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use previous stop path when is has been generated

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 10, 2022
…dation#1742)

* fix(behavior_path_planner): fix stop path for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use previous stop path when is has been generated

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2022
…dation#1742)

* fix(behavior_path_planner): fix stop path for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use previous stop path when is has been generated

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants