-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pure_pursuit): add maximum steering angle limit #1654
feat(pure_pursuit): add maximum steering angle limit #1654
Conversation
Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
Codecov Report
@@ Coverage Diff @@
## main #1654 +/- ##
==========================================
- Coverage 10.66% 10.65% -0.01%
==========================================
Files 1108 1108
Lines 78748 78792 +44
Branches 18640 18668 +28
==========================================
Hits 8397 8397
- Misses 61438 61476 +38
- Partials 8913 8919 +6
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your nice work.
…ion#1654) * feat(pure_pursuit): add maximum steering angle limit Signed-off-by: Berkay Karaman <berkay@leodrive.ai> * ci(pre-commit): autofix Signed-off-by: Berkay Karaman <berkay@leodrive.ai> Co-authored-by: Berkay Karaman <berkay@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ion#1654) * feat(pure_pursuit): add maximum steering angle limit Signed-off-by: Berkay Karaman <berkay@leodrive.ai> * ci(pre-commit): autofix Signed-off-by: Berkay Karaman <berkay@leodrive.ai> Co-authored-by: Berkay Karaman <berkay@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ion#1654) * feat(pure_pursuit): add maximum steering angle limit Signed-off-by: Berkay Karaman <berkay@leodrive.ai> * ci(pre-commit): autofix Signed-off-by: Berkay Karaman <berkay@leodrive.ai> Co-authored-by: Berkay Karaman <berkay@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ion#1654) * feat(pure_pursuit): add maximum steering angle limit Signed-off-by: Berkay Karaman <berkay@leodrive.ai> * ci(pre-commit): autofix Signed-off-by: Berkay Karaman <berkay@leodrive.ai> Co-authored-by: Berkay Karaman <berkay@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ion#1654) * feat(pure_pursuit): add maximum steering angle limit Signed-off-by: Berkay Karaman <berkay@leodrive.ai> * ci(pre-commit): autofix Signed-off-by: Berkay Karaman <berkay@leodrive.ai> Co-authored-by: Berkay Karaman <berkay@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Berkay Karaman berkay@leodrive.ai
Description
In current implementation of
pure_pursuit
controller does not check the maximum steering while calculating control command.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.