Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pure_pursuit): add maximum steering angle limit #1654

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Aug 22, 2022

Signed-off-by: Berkay Karaman berkay@leodrive.ai

Description

In current implementation of pure_pursuit controller does not check the maximum steering while calculating control command.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
@brkay54 brkay54 added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Aug 22, 2022
@brkay54 brkay54 self-assigned this Aug 22, 2022
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1654 (3f548ed) into main (27f9216) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1654      +/-   ##
==========================================
- Coverage   10.66%   10.65%   -0.01%     
==========================================
  Files        1108     1108              
  Lines       78748    78792      +44     
  Branches    18640    18668      +28     
==========================================
  Hits         8397     8397              
- Misses      61438    61476      +38     
- Partials     8913     8919       +6     
Flag Coverage Δ *Carryforward flag
differential 20.42% <0.00%> (?)
total 10.64% <0.00%> (ø) Carriedforward from d9c2fad

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...c/pure_pursuit/pure_pursuit_lateral_controller.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your nice work.

@TakaHoribe TakaHoribe merged commit 4e1ff9b into autowarefoundation:main Aug 29, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…ion#1654)

* feat(pure_pursuit): add maximum steering angle limit

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>

* ci(pre-commit): autofix

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
Co-authored-by: Berkay Karaman <berkay@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ion#1654)

* feat(pure_pursuit): add maximum steering angle limit

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>

* ci(pre-commit): autofix

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
Co-authored-by: Berkay Karaman <berkay@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ion#1654)

* feat(pure_pursuit): add maximum steering angle limit

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>

* ci(pre-commit): autofix

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
Co-authored-by: Berkay Karaman <berkay@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ion#1654)

* feat(pure_pursuit): add maximum steering angle limit

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>

* ci(pre-commit): autofix

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
Co-authored-by: Berkay Karaman <berkay@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…ion#1654)

* feat(pure_pursuit): add maximum steering angle limit

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>

* ci(pre-commit): autofix

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
Co-authored-by: Berkay Karaman <berkay@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@brkay54 brkay54 deleted the pp-check-max-steering branch October 19, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants