Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop for wrong-way car #1309

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Jul 11, 2022

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

Description

With the current implementation of obstacle_cruise_planner, the vehicle cruises for a wrong-way car by.

cruise.mp4

I fixed it to stop for a wrong-way car.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested a review from takayuki5168 July 11, 2022 14:25
@tkimura4
Copy link
Contributor Author

After the change.
https://user-images.githubusercontent.com/59680180/178289214-a32aeb88-e690-43ba-b77e-cdf2d14aa079.mp4

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1309 (5272e60) into main (b11a689) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main   #1309   +/-   ##
=====================================
  Coverage   9.49%   9.49%           
=====================================
  Files       1096    1096           
  Lines      76310   76310           
  Branches   16991   16991           
=====================================
  Hits        7249    7249           
  Misses     62450   62450           
  Partials    6611    6611           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.48% <0.00%> (ø) Carriedforward from b11a689

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b11a689...5272e60. Read the comment docs.

@tkimura4 tkimura4 requested a review from shmpwk July 11, 2022 14:38
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit db01212 into autowarefoundation:main Jul 11, 2022
@tkimura4 tkimura4 deleted the fix/cruise_wrong_way_car branch July 11, 2022 14:47
kosuke55 referenced this pull request in tier4/autoware.universe Jul 14, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request May 24, 2024
…tion#1309)

* remove diagnostics_updater

* add counter

* change node name

* rename

* style(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Nov 25, 2024
…efoundation#1655)

* feat(pointcloud preprocessor): add hysteresis to diag (autowarefoundation#1309)

* remove diagnostics_updater

* add counter

* change node name

* rename

* style(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: kotaro-hihara <kotaro.hihara@tier4.jp>

* fix(pointcloud_preprocessor): typo consecutive_concatenate_failures (autowarefoundation#1310)

---------

Signed-off-by: kotaro-hihara <kotaro.hihara@tier4.jp>
Co-authored-by: Shinnosuke Hirakawa <8327162+0x126@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware.universe that referenced this pull request Feb 6, 2025
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants