Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): make parameters const #10043

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 29, 2025

Description

make parameters and other related member variables const

NOTE: parameter update is disabled.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 29, 2025
Copy link

github-actions bot commented Jan 29, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 30, 2025
@soblin soblin enabled auto-merge (squash) January 30, 2025 04:55
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 129 lines in your changes missing coverage. Please review.

Project coverage is 29.03%. Comparing base (461dbc1) to head (a6f4a3f).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 120 Missing and 3 partials ⚠️
...r_path_goal_planner_module/goal_planner_module.hpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10043      +/-   ##
==========================================
- Coverage   29.21%   29.03%   -0.19%     
==========================================
  Files        1439     1442       +3     
  Lines      108115   108807     +692     
  Branches    42638    43105     +467     
==========================================
  Hits        31588    31588              
- Misses      73485    74133     +648     
- Partials     3042     3086      +44     
Flag Coverage Δ *Carryforward flag
differential 0.50% <0.00%> (?)
total 29.21% <0.00%> (ø) Carriedforward from 461dbc1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 0d030d7 into autowarefoundation:main Jan 30, 2025
44 of 46 checks passed
@soblin soblin deleted the refactor/goal-planner-const-param-and-member branch January 30, 2025 05:14
yhisaki pushed a commit to tier4/autoware.universe that referenced this pull request Feb 6, 2025
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
SakodaShintaro pushed a commit to tier4/autoware.universe that referenced this pull request Feb 7, 2025
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants