Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mission_planner fails when enable_correct_goal_pose param is true #5530

Open
3 tasks done
beyzanurkaya opened this issue Nov 9, 2023 · 3 comments
Open
3 tasks done
Assignees
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned) type:bug Software flaws or errors.

Comments

@beyzanurkaya
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

There are 2 reasons for this problem:

  1. The route_handler does not check for overlap lanelets for goal_lanelet, it only checks the closest lanelet to the goal_pose.
  2. When enable_correct_goal_pose is true, the goal_pose is calculated with the closest lanelet to it, disregarding the overlap lanelets. Since this lanelet is not found in the all_route_lanelets obtained from the route_handler, the error message Goal is not valid! Please check position and angle of goal_pose is sent. No route is being generated.
overlap-lanes.mp4

Expected behavior

All overlap lanelets should be checked to generate a proper route, the shortest among the possible routes should be selected, and the route should be generated.

Actual behavior

There is a proper route available based on the given start and goal positions, but it is not being generated.

Steps to reproduce

  1. set enable_correct_goal_pose to true
  2. download map.zip
  3. run Psim
  4. give a goal pose on red dot with a single click
    give-goal-pose

Versions

No response

Possible causes

No response

Additional context

No response

@beyzanurkaya beyzanurkaya added type:bug Software flaws or errors. component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Nov 9, 2023
@beyzanurkaya beyzanurkaya self-assigned this Nov 9, 2023
@beyzanurkaya beyzanurkaya changed the title route_handler fails when enable_correct_goal_pose param is true mission_planner fails when enable_correct_goal_pose param is true Nov 9, 2023
@beyzanurkaya beyzanurkaya removed the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 9, 2023
@kosuke55
Copy link
Contributor

@beyzanurkaya

All overlap lanelets should be checked to generate a proper route, the shortest among the possible routes should be selected, and the route should be generated.

thanks, I agree with your idea! Do you plan to work on this task?

@kosuke55
Copy link
Contributor

@beyzanurkaya
wow, thanks the PR #5533!!

Copy link

stale bot commented Jan 30, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned) type:bug Software flaws or errors.
Projects
None yet
Development

No branches or pull requests

2 participants