Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed texts and links in node diagram #558

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TimS120
Copy link

@TimS120 TimS120 commented May 26, 2024

Description

What I have done:

  • Translated all Japanese texts
  • Checked all links if they are broken and if the reference could be right (and fixed broken links of lateral_controller, longitudinal_controller and accel_map_calibrator)
  • Checked, if all group-blocks are behind the single-blocks (costmap_generator wasn’t reachable (the link behind it, because the group where the node was in it was over it))
  • Background color of car/traffic_light_classifier and pedestrian/traffic_light_classifier fixed

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

stale bot commented Jul 25, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant