Skip to content

Conversation

@chunfuwen
Copy link
Contributor

@chunfuwen chunfuwen commented Nov 25, 2025

Reverts #6420

Summary by CodeRabbit

Release Notes

  • Chores
    • Removed test configuration and implementation files related to managed save functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2025

Walkthrough

This pull request removes two related files from the libvirt test suite: the configuration file managedsave_edit.cfg and the corresponding Python test script managedsave_edit.py. The configuration file defined test variants for managed save/edit operations with different virsh options and accessibility controls. The Python script implemented the test logic for executing virsh managedsave, editing the VM configuration via XML manipulation, and verifying state transitions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that no other test files or configurations reference the deleted managedsave_edit test
  • Check that test suite discovery mechanisms or CI/CD pipelines don't explicitly call these removed test files
  • Confirm the removal is intentional and not part of a broader test restructuring that requires updates elsewhere

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the primary change: reverting the managedsave-edit test implementation by removing both the configuration file and test script.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-6420-managed_edit

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a76a11 and 4982040.

📒 Files selected for processing (2)
  • libvirt/tests/cfg/save_and_restore/managedsave_edit.cfg (0 hunks)
  • libvirt/tests/src/save_and_restore/managedsave_edit.py (0 hunks)
💤 Files with no reviewable changes (2)
  • libvirt/tests/src/save_and_restore/managedsave_edit.py
  • libvirt/tests/cfg/save_and_restore/managedsave_edit.cfg
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Python 3.9
  • GitHub Check: Python 3.8
  • GitHub Check: Python 3.12
  • GitHub Check: Python 3.11

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dzhengfy dzhengfy merged commit b89487d into master Nov 25, 2025
6 checks passed
Copy link
Contributor

@smitterl smitterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the original dependency avocado-framework/avocado-vt#4235 that we missed will take more time for completion, so approving this revert PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants