Removing maxphysadd testcase as it is not supported on ppc! #6661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe pull request updates a libvirt test configuration file to expand the CPU architecture exclusion list. In the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
libvirt/tests/cfg/cpu/vcpu_misc.cfg(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Python 3.9
- GitHub Check: Python 3.11
- GitHub Check: Python 3.12
- GitHub Check: Python 3.8
Comment on lines
+40
to
+42
| cpu_mode = "host-model" | ||
| # not applicable on ppc64 or ppc64le | ||
| no s390-virtio,aarch64,ppc64,ppc64le |
There was a problem hiding this comment.
Approve the architecture exclusion expansion, but fix indentation.
The logical change to exclude ppc64 and ppc64le architectures is correct and aligns with the PR objective.
However, line 41 uses tab characters for indentation instead of spaces, which is inconsistent with the rest of the file. Additionally, there appears to be trailing whitespace at the end of the comment line.
Apply this diff to fix the indentation and remove trailing whitespace:
- with_maxphysaddr:
cpu_mode = "host-model"
- # not applicable on ppc64 or ppc64le
+ # not applicable on ppc64 or ppc64le
no s390-virtio,aarch64,ppc64,ppc64leCommittable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In libvirt/tests/cfg/cpu/vcpu_misc.cfg around lines 40 to 42, the exclusion
comment line uses a tab for indentation and has trailing whitespace; replace the
tab with the same spaces used by surrounding lines (match existing file
indentation) and remove any trailing spaces at the end of the comment so the
line consistently uses spaces and has no trailing whitespace.
This feature is not supported in ppc64 or ppc64le systems so removing this testcase to be run on ppc systems. Signed-off-by: Anushree-Mathur <anushree.mathur@linux.ibm.com>
Anushree-Mathur
force-pushed
the
maxphysaddr
branch
from
b3d9ccc to
ba5d3d3
Compare
Contributor
Author
|
Before applying the patch: After applying the patch : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is not supported in ppc64 or ppc64le systems so removing this testcase to be run on ppc systems.
Signed-off-by: Anushree-Mathur anushree.mathur@linux.ibm.com
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.