Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mem file for vcpu_misc: snapshot scenario #5767

Merged
merged 1 commit into from
Jul 22, 2024
Merged

add mem file for vcpu_misc: snapshot scenario #5767

merged 1 commit into from
Jul 22, 2024

Conversation

nanli1
Copy link
Contributor

@nanli1 nanli1 commented Jul 9, 2024 •
edited
Loading

add --memspec MEM_FILE when virsh snapshot-create-as
Signed-off-by: nanli nanli@redhat.com

avocado run --vt-type libvirt --test-runner=runner --vt-machine-type q35 vcpu_misc.positive_test.snapshot 
 (1/1) type_specific.io-github-autotest-libvirt.vcpu_misc.positive_test.snapshot: PASS (75.38 s)

Other related

avocado run --vt-type libvirt --test-runner=runner --vt-machine-type q35 vcpu_misc

 (1/8) type_specific.io-github-autotest-libvirt.vcpu_misc.positive_test.snapshot: PASS (82.98 s)
 (2/8) type_specific.io-github-autotest-libvirt.vcpu_misc.positive_test.vendor_id: PASS (53.61 s)
 (3/8) type_specific.io-github-autotest-libvirt.vcpu_misc.positive_test.with_topology.vcpus_max_equal_topology: PASS (130.55 s)
 (4/8) type_specific.io-github-autotest-libvirt.vcpu_misc.positive_test.mode_max: PASS (53.86 s)
 (5/8) type_specific.io-github-autotest-libvirt.vcpu_misc.positive_test.managedsave_restore: PASS (60.59 s)
 (6/8) type_specific.io-github-autotest-libvirt.vcpu_misc.positive_test.with_maxphysaddr: PASS (54.29 s)
 (7/8) type_specific.io-github-autotest-libvirt.vcpu_misc.negative_test.with_topology.vcpus_max_exceed_topology: PASS (27.85 s)
 (8/8) type_specific.io-github-autotest-libvirt.vcpu_misc.negative_test.with_topology.vcpus_max_less_than_topology: PASS (27.56 s)

@nanli1 nanli1 marked this pull request as draft July 9, 2024 13:37
@nanli1 nanli1 force-pushed the add_mem_option_for_vpcu_misc_snap_creating branch 3 times, most recently from 5d53c60 to b180783 Compare July 10, 2024 01:06
@nanli1 nanli1 marked this pull request as ready for review July 10, 2024 01:08
@nanli1 nanli1 marked this pull request as draft July 10, 2024 01:35
@nanli1 nanli1 force-pushed the add_mem_option_for_vpcu_misc_snap_creating branch from b180783 to 06748dc Compare July 10, 2024 01:48
@nanli1 nanli1 marked this pull request as ready for review July 10, 2024 01:49
dzhengfy
dzhengfy reviewed Jul 12, 2024
View reviewed changes
libvirt/tests/cfg/cpu/vcpu_misc.cfg Outdated
@@ -8,6 +8,7 @@
- snapshot:
cpu_mode = "host-model"
test_operations = "do_snapshot"
snapshot_options = "{} --memspec /tmp/mem_file"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any place to clean this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ,Thanks

@nanli1
add mem file for vcpu_misc: snapshot scenario
cd40442 
   add --memspec MEM_FILE when virsh snapshot-create-as
Signed-off-by: nanli <nanli@redhat.com>
@nanli1 nanli1 force-pushed the add_mem_option_for_vpcu_misc_snap_creating branch from 06748dc to cd40442 Compare July 14, 2024 14:42
@nanli1 nanli1 requested a review from dzhengfy July 15, 2024 02:32
dzhengfy
dzhengfy approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@dzhengfy dzhengfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yingshun Yingshun merged commit b15f945 into autotest:master Jul 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yingshun Yingshun Yingshun approved these changes

@dzhengfy dzhengfy dzhengfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nanli1 @dzhengfy @Yingshun