Virtual_disk: add new cases for disk driver discard_no_unref attribute #5649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chunfuwen
reviewed
May 30, 2024
| @@ -0,0 +1,42 @@ | |||
| - virtual_disks.discard_no_unref: | |||
There was a problem hiding this comment.
can this share with https://github.com/autotest/tp-libvirt/blob/master/libvirt/tests/cfg/virtual_disks/virtual_disks_discard_granularity.cfg file, since they all address discard attribute
There was a problem hiding this comment.
They are different attributes. Discard_no_unref is a driver attribute which is in "". But discard_granularity is a blockio attribute which is in "".
chunfuwen
reviewed
Jun 3, 2024
| from provider.virtual_disk import disk_base | ||
|
|
||
|
|
||
| def result_check(vm, params, test): |
There was a problem hiding this comment.
python method naming convention: verb + noun. ,So maybe change to check_result
meinaLi
force-pushed
the
start_discard
branch
2 times, most recently
from
9e69a8a to
871576d
Compare
dzhengfy
reviewed
Jul 3, 2024
| libvirt.check_logfile(check_libvirtd_log, libvirtd_log_file) | ||
| test.log.info("Check read/write in guest.") | ||
| session = vm.wait_for_login() | ||
| session.cmd("mkfs.ext4 /dev/%s && mount /dev/%s /mnt" % (target_dev, target_dev)) |
There was a problem hiding this comment.
This test for disk IO in VM already has an utility function. Could you have a look at check_virtual_disk_io() in virttest/utils_libvirt/libvirt_disk.py ?
There was a problem hiding this comment.
This is an useful function. I've updated to use it.
Automate cases of discard_no_unref attribute: VIRT-301646 VIRT-301647 VIRT-301651 Signed-off-by: Meina Li <meili@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automate cases of discard_no_unref attribute: VIRT-301646 VIRT-301647 VIRT-301651