Added info overlay part #898
Conversation
|
@JoeSiu - thanks for your PR. Why would you want to put this data into the images, as they are used for training. This would distort the ability to learn. You have another PR where the car frequency data gets logged. This is more useful I think. |
|
@DocGarbanzo This part is mainly used for easier debugging. For example, when testing the stop sign detection, It's easier to see the current pilot's throttle as well as the bounding box for the stop sign directly on the camera image while using the mobile app or web controller, instead of checking the output from the shell in a separate window which I think is less convenient. It will indeed affect the training through which I didn't consider at first, sorry about that! |
|
@JoeSiu - thanks for addressing / solving all change requests. This looks very good to me now. Can you please do one last step and that is rebasing your branch on |
JoeSiu
force-pushed
the
info_overlay_part_dev
branch
from
0a4b1e4
to
7297288
Compare
|
@DocGarbanzo I have rebased the branch, thank you! |
| """ | ||
|
|
||
| # Store the infos which will be write to image | ||
| info_list = [] |
There was a problem hiding this comment.
What is the reason for this member to be a class member and not an instance member?
There was a problem hiding this comment.
@DocGarbanzo It is used so that info can be written directly from other parts like this and have a shared info_list
from donkeycar.parts.info_overlay import InfoOverlayer
InfoOverlayer().add("hello")
"hello" can then be written onto the image along with other info like throttle or angle. However, it is supposed to be used as a temporary method in this case for easier debugging.
JoeSiu
force-pushed
the
info_overlay_part_dev
branch
from
7297288
to
5de8283
Compare
a simple Info overlay that adds texts overlay to the camera images, might be useful for debugging. It can show the current fps if enabled (#897) as well as the current throttle and angle, or any other info by adding the inputs or by calling the 'add' function in InfoOverlayLogger.