Add Support for Video Games as a Medium of Control/Recording #1193
+110
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocGarbanzo
reviewed
Sep 1, 2024
| import numpy as np | ||
| from PIL import Image | ||
| import mss |
There was a problem hiding this comment.
Please have a look at the failed tests, you need to add the python packages into setup.cfg in the right place. Likely we only want to support that in the PC installation but not on the robot.
DocGarbanzo
requested changes
Sep 1, 2024
| self.sct = mss.mss() | ||
| self.running = True | ||
|
|
||
| self._monitor_thread = threading.Thread(target=self.take_screenshot, args=()) |
There was a problem hiding this comment.
Please have a look at other threaded parts. Threads are not started in the constructor but centrally in the car application, when adding the part as a threaded part - which is what you want to do for your part.
| self.frame = img_arr | ||
| return img | ||
|
|
||
| def update(self): |
There was a problem hiding this comment.
The method should not return but refresh the class member self.frame.
| assert self.frame is not None | ||
| return self.frame | ||
|
|
||
| def run_threaded(self): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two parts:
ScreenCamerais a part incamera.pywhich takes screenshots and uses those as camera images.VirtualControllerinactuator.pyis a part for an emulated Xbox controller which can be used to control a car in videogames.I used these two parts to make a (mostly) successful pilot in Forza Horizon 3: https://youtu.be/LIuH6aonYWU