Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix donkey gym bug #1052

Merged
merged 1 commit into from
Oct 19, 2022
Merged

fix donkey gym bug #1052

merged 1 commit into from
Oct 19, 2022

Conversation

sctse999
Copy link
Contributor

Simulator is broken because SIM_RECORD_DISTANCE and SIM_RECORD_ORIENTATION is not present in config.py

Temp comment out until further fix

Ezward
Ezward approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@Ezward Ezward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a merge bug on my part. I have an experimental branch of the simulator that outputs accumulated distances so we can simulate odometry. So those values are not present in the main simulator. This fix is fine for removing them.

@sctse999 sctse999 merged commit 36c4b70 into autorope:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ezward Ezward Ezward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sctse999 @Ezward