This repository was archived by the owner on Nov 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Mantid versions: latest & nightly #1463
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ently the latest Mantid (6.4.0)
… similar Dockerfiles
…be seen if it is needed
…ill then be available in all sub-environments as well
…tall - therefore these are installed on both the builder and the runner
…tement to download latest stable or latest nightly.
Codecov Report
@@ Coverage Diff @@
## main #1463 +/- ##
=======================================
Coverage 89.84% 89.84%
=======================================
Files 17 17
Lines 827 827
=======================================
Hits 743 743
Misses 84 84
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Pasarus
approved these changes
Aug 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of work
Create 2 main Dockerfiles: one for queue-processor; one for queue-processor with Mantid in the environment
Version of Mantid required (latest stable or latest nightly) can be passed as a build-arg (defaults to latest stable)
Dockerfile uses multi-stage builds to reduce final image size
Make use of conda-pack to reduce Image size. A tool that let’s you package a Conda environment into a standalone environment, with no need for the Conda toolchain. Once environment has been packaged that way, it can be copied into a new smaller image that only contains the self-contained environment
Remove unused function generating fake test data