Skip to content
This repository was archived by the owner on Nov 14, 2022. It is now read-only.

Conversation

@dtasev
Copy link
Contributor

@dtasev dtasev commented Apr 22, 2021

Summary of work

This provides some useful Debug launch and pre-launch tasks. They start up the Docker container (and do their best to kill it at the end, but that doesn't always work 😄).

The idea is that if you want to Debug the queue processor but don't want to install the Python environment - just run the Docker one, it will pull & run the container, then connect with the queue processor.

You still need ActiveMQ running - so a task Run ActiveMQ Docker is added. This needs to be run manually, as it can remain in the background indefinitely. It adds a delay to the startup, and the docker queue processor already takes a few seconds longer than without docker.

How to test your work

Instructions have been added in https://github.com/ISISScientificComputing/autoreduce/wiki/Just-Use-VSCode-&-Docker

Before merging ensure the release notes have been updated

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #1315 (0d66d27) into master (ab0146d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1315   +/-   ##
=======================================
  Coverage   53.52%   53.52%           
=======================================
  Files         108      108           
  Lines        4338     4338           
  Branches      549      549           
=======================================
  Hits         2322     2322           
  Misses       1967     1967           
  Partials       49       49           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0146d...0d66d27. Read the comment docs.

Dimitar Tasev added 4 commits April 22, 2021 15:01
Adds SELENIUM_REMOTE check in driver.py to select the remote driver

Reorders tasks to bring the docker ones on top
@dtasev dtasev merged commit 1296088 into master Apr 28, 2021
@dtasev dtasev deleted the 1328_vscode_docker_debug_AR-1328 branch April 28, 2021 07:23
dtasev pushed a commit that referenced this pull request Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants