Update dependencies to compile more easily #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's because I tried to compile autopy on my machine after editing some code of autopilot-rs.
|
Hi, sorry for the delay. Was hesitant to make this change initially since it breaks Python 2 compatibility, but now that Rust stable is supported by the latest PyO3 and we're well past the EOL for Python 2 I think it's warranted. Thanks for the contribution! |
|
Thanks for your explanation and your answer!
See you
Le mer. 9 sept. 2020 à 00:23, Michael Sanders <notifications@github.com> a
écrit :
… Hi, sorry for the delay. Was hesitant to make this change initially since
it breaks Python 2 compatibility, but now that Rust stable is supported by
the latest PyO3 and we're well past the EOL for Python 2 I think it's
warranted. Thanks for the contribution!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#55 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO5JHPR4SMC374WMAYO2G33SE2VGHANCNFSM4LXLOXRA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an Ubuntu 19.10 machine, I couldn't compile the project (issue with doctests that threw an error message at compilation when I was on the nightly branch specified in the README.md). So I replaced the pyo3 dependency with the latest version (v. 0.8.1) compatible with the autopy project. Thanks to this modification, I can compile directly from nightly without any problem and autopy works well.