Skip to content

Commit

Permalink
Add support for Python 3.8
Browse files Browse the repository at this point in the history
  • Loading branch information
@msanders
msanders committed Nov 11, 2019
1 parent 17084f1 commit 244e532
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ env:
# Note: TWINE_PASSWORD is set in Travis settings.

script:
- "pip install cibuildwheel==0.10.2 setuptools-rust==0.10.3"
- "pip install cibuildwheel==1.0.0 setuptools-rust==0.10.3"
- export RUST_BACKTRACE=1

This comment has been minimized.

Sign in to view

Copy link
@pevogam

pevogam Jun 24, 2020

Hi @msanders, I wonder did you encounter any troubles updating to Python 3.8? I am currently hitting an error in Travis CI and python 3.8 resulting in:

$ python --version

Python 3.8.0

$ pip --version

pip 19.3 from /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/pip (python 3.8)

8.30s$ if [[ $INSTALL_VARIANT == "pip" ]]; then travis_retry pip install -r packaging/pip_requirements.txt; fi

Collecting coverage==5.0.4

  Downloading https://files.pythonhosted.org/packages/98/02/6804fd81522ca3e9a057daf580d1a7d0fd26308ae20b64865df4de7a8bc8/coverage-5.0.4-cp38-cp38-manylinux1_x86_64.whl (228kB)

Collecting codecov==2.0.22

  Downloading https://files.pythonhosted.org/packages/4d/86/7135a1db448c3bd478a7bbd817bfe3d80200eec7a89d320d574644879528/codecov-2.0.22-py2.py3-none-any.whl

Collecting Pillow==7.0.0

  Downloading https://files.pythonhosted.org/packages/1a/6a/e944b190abffe5272a571084bc2fc59bb9051abea7f6720c36662d47c0e0/Pillow-7.0.0-cp38-cp38-manylinux1_x86_64.whl (2.1MB)

Collecting setuptools-rust==0.10.3

  Downloading https://files.pythonhosted.org/packages/8e/11/9372d95e9b1150da49aa752b848f24b0f6349555cbdba2c644cb719840c9/setuptools_rust-0.10.3-py3-none-any.whl

Collecting autopy==3.0.0

  Downloading https://files.pythonhosted.org/packages/d8/6d/bbc9381ef2e674bf512e6988c169a348d19f23d0038c7004ca4238e6712e/autopy-3.0.0.tar.gz

    ERROR: Command errored out with exit status 1:

     command: /home/travis/virtualenv/python3.8.0/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-nnuk1kl2/autopy/setup.py'"'"'; __file__='"'"'/tmp/pip-install-nnuk1kl2/autopy/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-nnuk1kl2/autopy/pip-egg-info

         cwd: /tmp/pip-install-nnuk1kl2/autopy/

    Complete output (5 lines):

    Traceback (most recent call last):

      File "<string>", line 1, in <module>

      File "/tmp/pip-install-nnuk1kl2/autopy/setup.py", line 8, in <module>

        from setuptools_rust import Binding, RustExtension

    ModuleNotFoundError: No module named 'setuptools_rust'

Have you seen anything like this before while testing this commit?

This comment has been minimized.

Sign in to view

Copy link
@pevogam

pevogam Jun 29, 2020

Nah, I fixed this by simply requiring 3.0.1 as a minimal version, I was still on 3.0.0 when I got this error.
- export CIBW_BEFORE_BUILD="pip install setuptools-rust==0.10.3 && source ./scripts/travis"
- export CIBW_SKIP=cp34-*\ $CIBW_SKIP
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ install:
- rustc -vV
- cargo -vV
- python -m pip install -U pip
- python -m pip install cibuildwheel==0.9.4 setuptools setuptools-rust==0.10.3
- python -m pip install cibuildwheel==1.0.0 setuptools setuptools-rust==0.10.3

build_script:
- cibuildwheel --output-dir wheelhouse
Expand Down

0 comments on commit 244e532

Please sign in to comment.