Fix: Remove fs #371
Merged
Fix: Remove fs #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamnamananand996
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Remove fs
Back in the early stage of Auto-SDK, we wrote an Auto ID package that saved x509 certificate on file, and if I remember correctly. In some environments, the use of fs in the code was creating issue, when not available (in browser especially) so we had to add the fs placeholder to then set a rule not to use it in browser.
Anyway, Auto ID has been deprecated and so all these functions using fs in auto-utils are not use anymore and therefore we don't need this rule.