Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improvements for federated learning and QoL #137

Open
wants to merge 74 commits into
base: master
Choose a base branch
from
Open

feat: improvements for federated learning and QoL #137

wants to merge 74 commits into from

Conversation

matteo4diani
Copy link
Contributor

  • Logger
  • Pre-Commit job with auto-format
  • Remove dead code
  • Centralize duplicated code for losses and utils
  • (dcph) Dropout
  • (dcph) Activations
  • (dcph) Optimizers
  • (dcph) Biases
  • (dcph) Early init
  • (dcph) Tests

@matteo4diani
ci: add .gitignore
8799bba
@matteo4diani
ci: add pre-commit with black
239aec0
@matteo4diani
style: reformat with black
2912fb2
@matteo4diani
test: correct test_dsm.py indentation
b5a764b
@matteo4diani
style: use tqdm.auto for better rendering
a3f0ea8
@matteo4diani
refactor: remove unused code
bf6fb01
@matteo4diani
refactor: add distinct init phase for dcph
20d3444
@matteo4diani
style: remove dead code
4a4e0e6
@matteo4diani
fix: tentative fix for early stopping
b4ad53f
@matteo4diani
fix: revert fix for early stopping
905fa5d
@matteo4diani
feat: add patience param to DeepCoxPH::fit
e768f91
@matteo4diani
refactor: set-up logging
80f028a
@matteo4diani
style: fix tqdm label
37d70f3
@matteo4diani
style: fix logs and warnings
b123535
@matteo4diani
style: fix assert messages
72d5eab
@matteo4diani
style: tentative fix for warnings.warn misprint
87337a7
@matteo4diani
style: revert tentative fix for warnings.warn misprint
d3e6f0c
@matteo4diani
style: redirect warnings to logger
e79186d
@matteo4diani
style: fix warnings
32dc810
@matteo4diani
style: revert warnings fix
f9d4d21
@matteo4diani
style: replace warnings with logs
2cd1769
@matteo4diani
style: add proper logging
15637b5
@matteo4diani
style: add log config
5743635
@matteo4diani
style: remove log config
abb9705
@matteo4diani
style: more log config
925ad01
@matteo4diani
style: add colored logs
768d401
@matteo4diani
style: fix invasive logs
63c92ef
@matteo4diani
style: fix invasive logs
447c64c
@matteo4diani
style: fix logger
265172a
@matteo4diani
style: fix logger
5d03707
@matteo4diani
feat(datasets): optionally return feature dict when loading support
7a0af3c
@matteo4diani
feat(dpch): add torch_module @Property
37b8a52
@matteo4diani
fix(dcph): assign default to optimizer in init_torch_model
2bdee98
@matteo4diani
fix(dcph): don't raise exception when calling predict_time_independen…
89ddad6 
…t before fix
@matteo4diani
fix(dcph): add default optimizer to init_torch_model
b8f1ad9
@matteo4diani
fix(dcph): predict_time_independent_risk fails on no torch module
a0ec736
@matteo4diani
fix(utils._dataframe_to_array): copy array if not writable
9066fa7
@matteo4diani
fix(utils._dataframe_to_array): copy array if not writable
e008bde
@matteo4diani
feat(dcph): add weight decay
cca0c0b
@matteo4diani
feat(dcph): add activation param
690bc47
@matteo4diani
fix(dcph): correct activation
1f42c82
@matteo4diani
feat(dcph): configurable dropout, activation, weight decay, bias
2d1eac3
@matteo4diani
docs(dcph): document new features
4fab724
@matteo4diani
ci(tests): add -v flag to unittest cmd
af2792c
@matteo4diani
refactor(logs): revert to standard python logs
dae6c25
@matteo4diani
refactore(logs): add logging.basicConfig() to __init__
37dadf9
@matteo4diani
refactor(logs): add better log config
bd069ce
@matteo4diani
refactor(logs): add 'autonlab' root logger
721096f
@matteo4diani
refactor(logs): revert custom root logger
fff591c
@matteo4diani
refactor(logs): add single logger
0e8fe99
@matteo4diani
refactor(logs): add nullhandler
8f8df71
@matteo4diani
refactor(logs): basicConfig for logs
58b568a
@matteo4diani
refactor(logs): remove basicConfig for logs
df45ead
@matteo4diani
refactor(dcph): use torch_module instead of torch_model[0]
b83ddab
@matteo4diani matteo4diani mentioned this pull request Nov 19, 2023
Closed
@chiragnagpal
Copy link
Collaborator

The diffs don't resolve with the previous commit. Something is broken.

Please only add diffs for federated learning, QoL improvements should be a separate commit.

Thanks.. !

@matteo4diani
Copy link
Contributor Author

This PR is just a container to keep track of changes I'm making in my fork, I will propose them in separate PRs. If we can re-open and add a "Do not merge" label it's useful for me to test CI on this repo.
PS: The diff is broken because I enforced formatting, something for which I'll open a new PR.

@chiragnagpal chiragnagpal reopened this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteo4diani @chiragnagpal