Skip to content

Handle scenario when None is passed as memory limit #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

rabsr
Copy link
Contributor

@rabsr rabsr commented Apr 4, 2021

Fixes #1117

@codecov
Copy link

codecov bot commented Apr 4, 2021

Codecov Report

Merging #1118 (c29ebcb) into development (f8bab15) will decrease coverage by 0.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1118      +/-   ##
===============================================
- Coverage        85.49%   84.94%   -0.55%     
===============================================
  Files              137      137              
  Lines            10557    10557              
===============================================
- Hits              9026     8968      -58     
- Misses            1531     1589      +58     
Impacted Files Coverage Δ
autosklearn/automl.py 84.61% <100.00%> (-0.15%) ⬇️
autosklearn/smbo.py 74.07% <0.00%> (-9.77%) ⬇️
...eline/components/feature_preprocessing/fast_ica.py 91.30% <0.00%> (-6.53%) ⬇️
autosklearn/util/pipeline.py 76.56% <0.00%> (-6.25%) ⬇️
..._preprocessing/select_percentile_classification.py 86.20% <0.00%> (-3.45%) ⬇️
autosklearn/evaluation/__init__.py 77.35% <0.00%> (-3.42%) ⬇️
...osklearn/metalearning/metafeatures/metafeatures.py 93.34% <0.00%> (-1.37%) ⬇️
...ine/components/classification/gradient_boosting.py 91.30% <0.00%> (-0.87%) ⬇️
autosklearn/estimators.py 92.30% <0.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8bab15...c29ebcb. Read the comment docs.

@rabsr
Copy link
Contributor Author

rabsr commented Apr 4, 2021

Not sure why test cases are failing. Looks like there is some issue in fetching data from openml

Copy link
Contributor

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks a lot!

@mfeurer mfeurer merged commit b46a918 into automl:development Apr 13, 2021
@rabsr rabsr deleted the fix_no_memory_limit branch April 13, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants