Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[style] Remove prefix typing and adapt to google style doc #307

Merged
merged 3 commits into from
Nov 11, 2021
Merged

[style] Remove prefix typing and adapt to google style doc #307

merged 3 commits into from
Nov 11, 2021

Conversation

nabenabe0928
Copy link
Collaborator

This PR addresses Issue #302.

@nabenabe0928 nabenabe0928 changed the base branch from master to development October 26, 2021 15:48
@codecov
Copy link

codecov bot commented Oct 26, 2021 •
edited
Loading

Codecov Report

Merging #307 (cd50785) into development (4a29852) will increase coverage by 0.03%.
The diff coverage is 94.30%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #307      +/-   ##
===============================================
+ Coverage        82.09%   82.12%   +0.03%     
===============================================
  Files              151      151              
  Lines             8651     8650       -1     
  Branches          1322     1322              
===============================================
+ Hits              7102     7104       +2     
+ Misses            1084     1082       -2     
+ Partials           465      464       -1
Impacted Files Coverage Δ
autoPyTorch/evaluation/abstract_evaluator.py 74.78% <ø> (ø)
...PyTorch/pipeline/traditional_tabular_regression.py 25.86% <0.00%> (ø)
autoPyTorch/utils/parallel.py 100.00% <ø> (ø)
autoPyTorch/pipeline/create_searchspace_util.py 30.17% <25.00%> (ø)
autoPyTorch/evaluation/tae.py 66.96% <83.33%> (ø)
autoPyTorch/data/tabular_target_validator.py 91.75% <88.88%> (ø)
autoPyTorch/api/base_task.py 84.63% <100.00%> (ø)
autoPyTorch/data/base_feature_validator.py 100.00% <100.00%> (ø)
autoPyTorch/data/base_target_validator.py 97.95% <100.00%> (ø)
autoPyTorch/data/base_validator.py 92.00% <100.00%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a29852...cd50785. Read the comment docs.

@nabenabe0928 nabenabe0928 force-pushed the 302-style-adapt-to-reg-cocktail branch 2 times, most recently from f879bd3 to 05dd311 Compare October 26, 2021 20:45
ravinkohli
ravinkohli suggested changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@ravinkohli ravinkohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for this PR. I have left 2 minor comments and 1 major comment. I hope they can be resolved.

@nabenabe0928 nabenabe0928 changed the base branch from development to master November 4, 2021 12:56
@nabenabe0928 nabenabe0928 changed the base branch from master to development November 4, 2021 12:57
@nabenabe0928 nabenabe0928 requested review from ravinkohli and ArlindKadra and removed request for franchuterivera, ArlindKadra and ravinkohli November 5, 2021 11:14
@nabenabe0928 nabenabe0928 force-pushed the 302-style-adapt-to-reg-cocktail branch from 71e8d27 to 2828fea Compare November 9, 2021 15:25
@nabenabe0928
[style] Remove prefix typing and adapt to google style doc
ea3dc91 
The changes are the following:
1. [google doc style] Arguments --> Args
2. [style] typing.xxx --> xxx
3. [mypy] torch.tensor --> torch.Tensor
@nabenabe0928 nabenabe0928 force-pushed the 302-style-adapt-to-reg-cocktail branch from 3e9c1f7 to ea3dc91 Compare November 9, 2021 15:36
@ravinkohli ravinkohli merged commit 3659407 into automl:development Nov 11, 2021
github-actions bot pushed a commit that referenced this pull request Nov 11, 2021
nabenabe0928: [style] Remove prefix typing and adapt to google styl…
a4a7a02 
…e doc (#307)
@ravinkohli ravinkohli linked an issue Nov 11, 2021 that may be closed by this pull request
[FIX] Coding style improvements in development branch #302
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravinkohli ravinkohli ravinkohli requested changes

@ArlindKadra ArlindKadra Awaiting requested review from ArlindKadra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] Coding style improvements in development branch
2 participants
@nabenabe0928 @ravinkohli