Skip to content

Redundant imputation for categorical columns #374

Closed
@ravinkohli

Description

@ravinkohli

NOTE: ISSUES ARE NOT FOR CODE HELP - Ask for Help at https://stackoverflow.com

Your issue may already be reported!
Also, please search on the issue tracker before creating one.

  • I'm submitting a ...
    • bug report

Issue Description

We are already imputing categorical columns in the feature validator here. However, we still use the SimpleImputer in the pipeline to impute categorical columns which are redundant because we would not have any nans in the categorical columns by this time, see here. This will also save us a hyperparameter during the search.

Expected Behavior

The redundancy has no effect on the output of the simple imputer.

Current Behavior

The redundancy has no effect on the output of the simple imputer.

Possible Solution

Remove categorical imputer from SimpleImputer.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions