Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

torch.Tensor or np.ndarray? #309

Open
nabenabe0928 opened this issue Oct 29, 2021 · 3 comments
Open

torch.Tensor or np.ndarray? #309

nabenabe0928 opened this issue Oct 29, 2021 · 3 comments
Labels
refactoring Improvement of readability and abstract codes

Comments

@nabenabe0928
Copy link
Contributor

nabenabe0928 commented Oct 29, 2021 •
edited
Loading

About autoPytorch/pipeline/components/trainer/*.py in refactor_development_regularization_cocktail branch, most data have the typing of np.ndarray, but aren't they torch.Tensor?
@ravinkohli
Copy link
Contributor

they are, we should fix this as well.

@nabenabe0928
Copy link
Contributor Author

Actually, there are many mypy error regarding wrong typing expressions, so let's fix after the big merge.

@ravinkohli
Copy link
Contributor

sure.

@ravinkohli ravinkohli added the refactoring Improvement of readability and abstract codes label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Improvement of readability and abstract codes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ravinkohli @nabenabe0928