Skip to content

Wrong implementation of shake-drop #283

Closed
@ArlindKadra

Description

if not is_training:
# Move to torch.randn(1) for reproducibility
bl = torch.tensor(1.0) if torch.randn(1) <= pl else torch.tensor(0.0)
if is_training:
bl = torch.tensor(pl)

We noticed with @ravinkohli that the implementation is not right for shake-drop. The if conditions should be reversed, only during test it should be fixed.

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions