Eagerly push metrics when pushInterval is 0 #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
July 18, 2023 11:30
…ith histogram buckets (will likely be resolved upstream)
brettimus
changed the title
arendjr
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #98
Tested with a Supabase Edge Function locally and it works.
(To test with an edge function, I published the changes to the core lib as a package called
brettermetricson npm, then imported in Deno viahttps://esm.sh/brettermetrics@0.6.0)Note that this is only a hotfix for experimental support in FaaS environments. We can do a follow-up PR to hash out things like configuration, error logging, etc.