Skip to content

Initial Gravel Gateway Support #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Conversation

brettimus
Copy link
Collaborator

@brettimus brettimus commented Aug 2, 2023

This is a change to support autometrics-ts when used with the gravel aggregation gateway.

Allow a clearmode="family" label on the build_info metrics

Aggregating a gauge like build_info requires a special label.

We want to clear previous build_info metrics when new ones are pushed.

Grave Gateway requires that you add a clearmode label to do this.

Objective labels must always be present

Gravel Gateway will reject two metrics of the same name if one of them has a subset of the labels of the other.

This means to be able to support functions that have objectives, as well as functions that don't, we need to default to setting the objective_* labels to the empty string.

Looking to the Future

  • Add support for specifying the job name
  • Check that pushing build_info with a new job name does not clear all existing build_info metrics with different job names

@brettimus brettimus changed the title [WIP] Gravel Gateway Support Initial Gravel Gateway Support Aug 3, 2023
@brettimus brettimus merged commit d419557 into main Aug 3, 2023
@brettimus brettimus deleted the always-send-objective-labels branch August 3, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants