Bug 1763005 - add registry-proxy support #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shawn-hurley
left a comment
shawn-hurley
left a comment
There was a problem hiding this comment.
looks pretty good to me
@joelanford want to take a look as well?
The registry-proxy GET /v2 returns a WWW-Authenticate header with only a realm: .../v2/auth the APIV2Adapter simply gets a token for /v2/auth which is not valid for registry-proxy which seems to require a scoped token. In this PR, we added a new RegistryProxyAdapter that now requires the apbs to be listed in the configuration. For each of those images listed, we will add them to the scope when we ask for the token. This allows the broker access to fetch the apb images. Also, added a test to ensure registry proxy errors when no images are defined and added a unit test for getTokenWithScope.
jmrodri
force-pushed
the
work-with-registry-proxy
branch
from
e48ead1 to
4d9e931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registry-proxy GET /v2 returns a WWW-Authenticate header with only a
realm: .../v2/auth the APIV2Adapter simply gets a token for /v2/auth
which is not valid for registry-proxy which seems to require a scoped
token.
In this PR, we added a new RegistryProxyAdapter that now requires the
apbs to be listed in the configuration. For each of those images listed,
we will add them to the scope when we ask for the token. This allows the
broker access to fetch the apb images.
Also, added a test to ensure registry proxy errors when no images are defined
and added a unit test for getTokenWithScope.