Feature/docstrings #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisBrunner
previously requested changes
Sep 1, 2021
There was a problem hiding this comment.
Really nice initiative, lots of good stuff in there, especially the examples, however a lot of the description aren't really readable English and use confusing language (e.g. every single control_ endpoint use a different phrasing even though they all do nearly the same thing)
I commented on most of the issues but this need a few iterations of polishing the descriptions
LouisBrunner
requested review from
tallpress and
LouisBrunner
and removed request for
LouisBrunner
tallpress
reviewed
Sep 9, 2021
very nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added docstrings to all valid functions within Eva.py
Fixes #77
There was also a very minor bug within control_resume() where it was waiting for the wrong state.