lint views/layouts

[20wildmanj]

Summary

Summary generated by Reviewpad on 10 Sep 23 17:49 UTC

This pull request includes the following changes:

• In the file admin.html.erb, the class attribute of a content_tag block has been updated to ensure it always has a value.

• In the file app/views/layouts/application.html.erb, several changes have been made including adding an external stylesheet, modifying the dynamic content of the <title> tag, updating the error message for dropped courses, changing the rendering of flash messages, removing a blank line, adding a script tag for a GitHub button, and modifying the content for JavaScripts.

Overall, these changes involve adding conditional logic, improving error messages, and enhancing the rendering of flash messages.

Description

• lint views/layouts using bundle exec erblint app/views/*(folder)/*(file).html.erb -a

Motivation and Context

• Part of summer linting

How Has This Been Tested?

• make sure doorkeeper renders properly (navigate via "Manage Autolab"->"Manage API applications")
• ensure navbar renders properly for all user types (instructor, course assistant, student)
  • Instructor navbar should look like this:
    
    • ensure all button links work
    • try to sudo (go to Manage Course), and then see that unsudo button shows up on navbar to get out of sudo view
    • ensure gradebook is instructor gradebook
  • Course assistant navbar should look like this (minus the Manage Autolab button):
    • 
      • Make sure course assistant has a section assigned, then see that button to view section gradebook shows up, and that link correctly goes to gradebook for that section
  • student navbar:
    
    • ensure that button to view gradebook works and goes to student gradebook
  • Make sure admin navbar options work

Checklist:

• I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting

[KesterTan]

LGTM