Lint views/scoreboards #1959
Merged
Lint views/scoreboards #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KesterTan
reviewed
Sep 10, 2023
NicholasMy
pushed a commit
to UB-CSE-IT/Autolab
that referenced
this pull request
Jan 5, 2024
* lint views/scoreboards * Address PR comment (cherry picked from commit e836bcc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary generated by Reviewpad on 12 Sep 23 20:45 UTC
This pull request includes two patches.
The first patch makes changes to the
app/views/scoreboards/_form.html.erbandapp/views/scoreboards/show.html.erbfiles. It updates the styling and adds a link to learn more about custom scoreboards. Additionally, it improves the formatting and readability of the code.The second patch addresses a comment made in a previous pull request. It modifies the
app/views/scoreboards/_form.html.erbfile to fix an issue with the column specification.Overall, these patches aim to improve the linting and functionality of the views related to scoreboards.
Description
erblintonviews/scoreboardsusingbundle exec erblint app/views/scoreboards/*.html.erb -aMotivation and Context
How Has This Been Tested?
Checklist:
overcommit --install && overcommit --signto use pre-commit hook for linting