refactor: remove unnecessary Zustand store persistence #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonenMars
force-pushed
the
ronen/refactor/remove-persistency-from-irrelevant-zustands-stores
branch
from
c8e98ee to
a1f207c
Compare
RonenMars
force-pushed
the
ronen/refactor/remove-persistency-from-irrelevant-zustands-stores
branch
2 times, most recently
from
2500963 to
27e8994
Compare
RonenMars
force-pushed
the
ronen/refactor/remove-persistency-from-irrelevant-zustands-stores
branch
from
d6bdf1d to
fb5a187
Compare
Remove persist middleware from stores that should fetch fresh data or contain transient state. This prevents stale data issues and improves app reliability. Stores no longer persisted: - useCacheStore (integrations cache) - useOrgConnectionsStore (org connections) - useOrganizationStore (user/org data - fetch fresh on auth) - useProjectStore (project lists - fetch fresh) - useBuildFilesStore (build info can change) Removed unused code: - useDashboardStore (dead code - never imported) - dashboardStore.interface.ts - Unused StoreName enum entries Stores keeping persistence (legitimate UX/preferences): - useLoggerStore (debug log history) - useFileStore (open files per project) - useManualRunStore (run configuration) - useTemplatesStore (template cache) - useTourStore (completed tours) - useSharedBetweenProjectsStore (UI preferences) - useTablePreferencesStore (table settings) - useEventsDrawerStore (drawer entity/section state)
Remove 9 unused properties and their setters that were defined but never used anywhere in the codebase: - isChatbotFullScreen / setIsChatbotFullScreen - fullScreenEditor / setFullScreenEditor - expandedProjectNavigation - projectSplitScreenWidth / setProjectSplitScreenWidth - lastVisitedUrl / setLastVisitedUrl
…iddleware authentication logic
…tegrationSchema` and update its auth type to `ApiToken`
RonenMars
force-pushed
the
ronen/refactor/remove-persistency-from-irrelevant-zustands-stores
branch
from
465cb18 to
4b00840
Compare
…t instead of Auth Token
…use it for verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
useDashboardStore(dead code)StoreNameenum by removing unused entriesMotivation
Several stores were persisting data that should be fetched fresh from the backend, leading to potential stale data issues:
Changes
Stores - Persist Removed (5)
useCacheStoreuseOrgConnectionsStoreuseOrganizationStoreuseProjectStoreuseBuildFilesStoreDeleted - Dead Code (1)
useDashboardStoreStores - Persist Kept (8)
useLoggerStoreuseFileStoreuseManualRunStoreuseTemplatesStoreuseTourStoreuseSharedBetweenProjectsStoreuseTablePreferencesStoreuseEventsDrawerStoreCleanup
StoreNameenum entries:project,organization,user,cache,drawer,dashboard,buildFilessrc/store/useDashboardStore.tssrc/interfaces/store/dashboardStore.interface.tsWhat type of PR is this? (check all applicable)