Improve averaging checkpoints and creating model #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiqiangdon
requested review from
sxjscience,
bryanyzhu,
FANGAreNotGnu and
suzhoum
|
Job PR-2135-1167dd7 is done. |
sxjscience
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
LGTM. Thanks for fixing this. We need to rerun our experiments with larger backbones since the average state becomes float64. @Raldir
zhiqiangdon
changed the title
bryanyzhu
approved these changes
Sep 15, 2022
suzhoum
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_modelintocreate_modelandcreate_fusion_modelto improve modularization.create_modelis only in charge of creating a single model, which will be used in creating models in the siamese matcher.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.