Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: comment on PR when automated commits are made #7

Closed
scarf005 opened this issue Sep 2, 2023 · 3 comments
Closed

feature request: comment on PR when automated commits are made #7

scarf005 opened this issue Sep 2, 2023 · 3 comments

Comments

@scarf005
Copy link

scarf005 commented Sep 2, 2023

Hi, could the app add comments to PR as well using parameters such as comment?

Rationale

I feel this needs a warning somewhere in the PR template or the contributor docs. If the bot pushes a commit to the branch, and a contributor is fairly new to git, they may not know they'll need to pull the changes before pushing their own.

Originally posted by @olanti-p in cataclysmbnteam/Cataclysm-BN#3111 (comment)

Automated commits may cause confusion for newcomers to Git, leading to merge conflicts. Adding comments with these commits could guide them on how to resolve this issue. I considered the approach in #6, but it requires pull_request_target, which goes against the core purpose of autofix-ci. I'd like to open a PR for this feature, but it seems the API server code is in a private repository.

@mhils
Copy link
Member

mhils commented Oct 8, 2023

Hi,

I implemented this at https://github.com/autofix-ci/action/tree/comments, see mhils/autofixer#8 for an example. Does that match what you were looking for?

@scarf005
Copy link
Author

scarf005 commented Oct 8, 2023

yes, this is exactly what i've been looking for. it will help new contributors immensely. thank you!

@scarf005 scarf005 closed this as completed Oct 8, 2023
mhils added a commit that referenced this issue Oct 8, 2023
@mhils
Copy link
Member

mhils commented Oct 8, 2023

Awesome, thanks! This is now live in v1.2 :)

scarf005 added a commit to scarf005/Cataclysm-BN that referenced this issue Oct 8, 2023
scarf005 added a commit to scarf005/Cataclysm-BN that referenced this issue Oct 8, 2023
github-merge-queue bot pushed a commit to cataclysmbnteam/Cataclysm-BN that referenced this issue Oct 10, 2023
* ci: add comment when autofix is invoked

see: autofix-ci/action#7

* Apply suggestions from code review

Co-authored-by: Olanti <olanti-p@yandex.ru>

---------

Co-authored-by: Olanti <olanti-p@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants