[DAS 336] - Update Acc Admin models and endpoints #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrotech
requested review from
sajith-subramanian and
nishchhaldagar
and removed request for
sajith-subramanian
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| @@ -110,7 +111,7 @@ public ProjectPatchResponse() | |||
| ///Monetary value of the project | |||
| /// </value> | |||
| [DataMember(Name="value", EmitDefaultValue=false)] | |||
| public decimal? Value { get; set; } | |||
| public decimal Value { get; set; } | |||
There was a problem hiding this comment.
why change this to non optional?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nishchhaldagar
approved these changes
Jun 9, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Account Admin SDK to reflect new model names, enhance filtering/pagination for companies, and align endpoints with renamed classes.
- Updated license header branding and bumped package version.
- Renamed generated model classes (removed
Responsesuffix) and fixed field types. - Added company filtering enums and a paginated companies endpoint with updated return types.
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| construction/accountadmin/source/Model/ProjectUsersImport.gen.cs | Renamed ProjectUsersImportResponse → ProjectUsersImport |
| construction/accountadmin/source/Model/ProjectUserDetails.gen.cs | Renamed ProjectUserResponse → ProjectUserDetails |
| construction/accountadmin/source/Model/ProjectPatch.gen.cs | Renamed ProjectPatchResponse → ProjectPatch |
| construction/accountadmin/source/Model/ProjectCompanies.gen.cs | Renamed CompanyResponse → ProjectCompanies |
| construction/accountadmin/source/Model/FilterCompanySort.gen.cs | Added FilterCompanySort enum for company sorting |
| construction/accountadmin/source/Model/FilterCompanyFields.gen.cs | Added FilterCompanyFields enum for selecting company fields |
| construction/accountadmin/source/Model/CompanyOrFilters.gen.cs | Added CompanyOrFilters enum for OR-style filtering |
| construction/accountadmin/source/Model/CompanyImport.gen.cs | Renamed CompanyImportResponse → CompanyImport and made counts non-nullable |
| construction/accountadmin/source/Model/CompaniesPage.gen.cs | Introduced CompaniesPage model for paginated company lists |
| construction/accountadmin/source/Model/BusinessUnitsPayload.gen.cs | Renamed BusinessUnitsRequestPyload → BusinessUnitsPayload and updated list type |
| construction/accountadmin/source/Model/BusinessUnitsObject.gen.cs | Renamed BusinessUnitsRequest → BusinessUnitsObject |
| construction/accountadmin/source/Model/BusinessUnits.gen.cs | Renamed BusinessUnitsResponse → BusinessUnits, adjusted property |
| construction/accountadmin/source/Model/AccountCompanyAddress.gen.cs | Added AccountCompanyAddress model for address details |
| construction/accountadmin/source/Model/AccountCompany.gen.cs | Added AccountCompany model with expanded company fields |
| construction/accountadmin/source/Http/ProjectsApi.gen.cs | Updated ProjectsApi return types to use ProjectPatch and ProjectsPage |
| construction/accountadmin/source/Http/ProjectUsersApi.gen.cs | Updated user endpoints to use ProjectUserDetails, import page |
| construction/accountadmin/source/Http/CompaniesApi.gen.cs | Added GetCompaniesWithPaginationAsync, updated model return types |
| construction/accountadmin/source/Http/BusinessUnitsApi.gen.cs | Updated business units endpoints to use new payload/response types |
| construction/accountadmin/source/Http/AccountUsersApi.gen.cs | Updated import user endpoint to use UserImport |
| Directory.Packages.props | Bumped Autodesk.Construction.AccountAdmin package to 2.2.1 |
Comments suppressed due to low confidence (3)
construction/accountadmin/source/Model/BusinessUnits.gen.cs:53
- Rename the property
VarBusinessUnitstoBusinessUnitsfor consistency and clarity, removing theVarprefix.
public List<BusinessUnit> VarBusinessUnits { get; set; }
construction/accountadmin/source/Model/FilterCompanySort.gen.cs:50
- Use PascalCase for enum members, e.g., rename
Nameasc→NameAscto improve readability and follow C# conventions.
Nameasc,
construction/accountadmin/source/Model/AccountCompanyAddress.gen.cs:53
- The property name
Typeis very generic; consider renaming toAddressTypeto clarify its purpose and avoid confusion withSystem.Type.
public string Type { get; set; }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update Acc Admin models and endpoints
Branch Name?
DAS-336-update-acc-admin-models