[DAS 336] - Update Acc Admin models and endpoints #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrotech
requested review from
sajith-subramanian and
nishchhaldagar
and removed request for
sajith-subramanian
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Account Admin models and endpoints to align with the latest API schema by renaming several response classes and modifying property types. Key changes include renaming model classes (e.g. from ProjectPatchResponse to ProjectPatch), removing nullable types where not required, and updating HTTP API method signatures to use the new model names.
Reviewed Changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| construction/accountadmin/source/Model/ProjectPatch.gen.cs | Renamed class from ProjectPatchResponse to ProjectPatch and updated the Value property from nullable to non-nullable. |
| construction/accountadmin/source/Model/ProjectCompanies.gen.cs | Renamed CompanyResponse to ProjectCompanies for clearer domain context. |
| construction/accountadmin/source/Model/BusinessUnitsPayload.gen.cs & related BusinessUnits files | Corrected naming from BusinessUnitsRequestPyload to BusinessUnitsPayload and updated associated references. |
| construction/accountadmin/source/Http/*.gen.cs | Updated endpoint return types and signatures to use the new model names across various API interfaces. |
Files not reviewed (1)
- Directory.Packages.props: Language not supported
Comments suppressed due to low confidence (3)
construction/accountadmin/source/Model/ProjectCompanies.gen.cs:37
- [nitpick] The renaming from 'CompanyResponse' to 'ProjectCompanies' improves clarity by better reflecting the domain context. Ensure that documentation and consumers of this class are updated accordingly.
/// ProjectCompanies
construction/accountadmin/source/Http/BusinessUnitsApi.gen.cs:196
- [nitpick] Renaming 'BusinessUnitsRequestPyload' to 'BusinessUnitsPayload' fixes a typographical error and improves consistency. Please verify that all related references and documentation reflect this change.
request.Content = Marshalling.Serialize(businessUnitsPayload); // http body (model) parameter
construction/accountadmin/source/Model/ProjectPatch.gen.cs:114
- Changing the 'Value' property from a nullable decimal to a non-nullable type may lead to runtime exceptions if the data is missing. Please confirm that the API contract guarantees a valid value for this field.
public decimal Value { get; set; }
| @@ -110,7 +111,7 @@ public ProjectPatchResponse() | |||
| ///Monetary value of the project | |||
| /// </value> | |||
| [DataMember(Name="value", EmitDefaultValue=false)] | |||
| public decimal? Value { get; set; } | |||
| public decimal Value { get; set; } | |||
There was a problem hiding this comment.
why change this to non optional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update Acc Admin models and endpoints
Branch Name?
DAS-336-update-acc-admin-models