Skip to content

Fix: Lazy-initialize storage class to prevent unwanted migration generation #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix: Lazy-initialize storage class to prevent unwanted migration generation #113

merged 1 commit into from
Nov 14, 2023

Conversation

samupl
Copy link
Contributor

@samupl samupl commented Oct 13, 2023

Fixes the issue described in #112 - the storage class is now lazily generated by a callable that reads the IMPORT_EXPORT_CELERY_STORAGE setting.

This makes the migrations happy even if you change IMPORT_EXPORT_CELERY_STORAGE after the migrations were applied.

@samupl samupl mentioned this pull request Oct 13, 2023
Open
@samupl
Copy link
Contributor Author

samupl commented Oct 13, 2023

@timthelion Could you please review?

PetrDlouhy
PetrDlouhy approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@PetrDlouhy PetrDlouhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes are pretty straightforward and they should be merged.
I am using this code already.

@PetrDlouhy PetrDlouhy merged commit d8357e7 into auto-mat:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetrDlouhy PetrDlouhy PetrDlouhy approved these changes

@paivatidis paivatidis paivatidis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samupl @PetrDlouhy @paivatidis