Pass current menu to popup-menu-fallback#83
Open
wangii wants to merge 1 commit intoauto-complete:masterfrom
Open
Pass current menu to popup-menu-fallback#83wangii wants to merge 1 commit intoauto-complete:masterfrom
wangii wants to merge 1 commit intoauto-complete:masterfrom
Conversation
So that the custom fallback can operate on menu directly. Or there is a better way? thanks
Contributor
|
This will break compatibility. I rather prefer executing fallback with setting a special variable to the menu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that the custom fallback can operate on menu directly. Or there is a better way? thanks
Sign-off-by: Linan Wang