perf(popup.el): enable lexical binding #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me. Is there a reason this is still draft? 🤔 |
jcs090218
approved these changes
Aug 19, 2023
|
Oh, I was going to review the writing more but it's ok! |
jcs090218
approved these changes
Aug 19, 2023
popup.el
Outdated
| @@ -1,4 +1,4 @@ | |||
| ;;; popup.el --- Visual Popup User Interface | |||
| ;;; popup.el --- Visual Popup User Interface -*- lexical-binding: t -*- | |||
There was a problem hiding this comment.
The standard is two spaces after the description. 🤔 Can you change it for me? Thanks!
No worries. I can wait until this is ready! Just let me know when it's ready to merge! :) |
LemonBreezes
force-pushed
the
enable-lexical-binding
branch
from
6be32a9
to
5f9fe30
Compare
I just force-pushed and it closed the PR. Is it possible to re-open this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon inspecting the code, I do not see anything can present a problem with enabling
lexical-binding. One day Emacs will enable lexical binding by default so it's better merge this earlier to reduce the risk of a mass config breakage event.