update go workflows, add slog adapter #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/core
area/dependencies
ecordell
approved these changes
Jul 17, 2025
pkg/proxy/authn_test.go
Outdated
| @@ -221,7 +221,11 @@ func GetFreePort(listenAddr string) (int, error) { | |||
| if err != nil { | |||
| return 0, err | |||
| } | |||
| defer dummyListener.Close() | |||
| defer func() { | |||
There was a problem hiding this comment.
nit: maybe just run this block after the line below, non-deferred, and then bubble the error up?
vroldanbet
force-pushed
the
update-go-workflows
branch
from
a61996d to
c2e571f
Compare
vroldanbet
force-pushed
the
update-go-workflows
branch
from
4b884a0 to
b8d3035
Compare
ecordell
approved these changes
Jul 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-workflowswas just released in version 1.0.0, so it was a good opportunity to move, as it's such an essential piece of this project.I also updated SpiceDB dependency, and fixed some linter errors, and greated a klog-to-slog adapter for
go-wofklows.