Undisable `noImplicitAny` #84

tstirrat15 · 2025-10-09T23:28:43Z

Description

Part of getting this codebase closer to strictly following Typescript's recommendations, which provides better type-safety and ideally better behavior.

The idea behind this one is that if typescript can't infer the type of a function argument, especially in a callback function, it will type it as any. This is the "implicit" any in the rule. This configuration change makes typescript yell at you about it.

I don't think I uncovered any actual bugs here, but it means the guardrails should be better.

Changes

Will annotate.

Testing

Review. See that tests pass.

vercel · 2025-10-09T23:28:49Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
playground	Ready	Preview	Comment	Dec 4, 2025 4:14pm

alecmerdler · 2025-10-17T19:42:11Z

src/playground-ui/debouncer.ts

  };

+  // TODO: this is creating a new `run` on every render. Refactor so that the reference is stable,
+  // or else use an off-the-shelf debounce.


https://tanstack.com/pacer/latest/docs/framework/react/reference/functions/usedebouncer

Yeah, gonna treat this as a follow-on.

alecmerdler

awesome

tstirrat15 · 2025-10-09T23:29:13Z

src/playground-ui/debouncer.ts

+  // TODO: this is creating a new `run` on every render. Refactor so that the reference is stable,
+  // or else use an off-the-shelf debounce.


This is something that I noticed as I was reading through code; fixing it was more involved than I wanted to do in this PR.

tstirrat15 · 2025-10-09T23:29:38Z

src/playground-ui/visjs-network.d.ts

@@ -0,0 +1,6 @@
+declare module "visjs-network" {
+  // TODO: go reverse-engineer these types


Or else get rid of this feature. I've never been that stoked on it.

tstirrat15 · 2025-10-09T23:30:32Z

src/spicedb-common/components/relationshipeditor/customcells.ts

+  type DataEditorProps,
+  type GridCell,


I don't know if there's a difference in behavior by typescript/the bundler when doing this, but it makes things more explicit for a reader.

tstirrat15 · 2025-10-09T23:33:14Z

src/spicedb-common/components/relationshipeditor/commentcell.tsx

 }

-const CommentCellEditor = (props: {
+type CommentCellEditorProps = {


There's several of this kind of change - making props into their own type, since the function is used as an arg to something else.

tstirrat15 · 2025-10-09T23:33:33Z

src/spicedb-common/components/relationshipeditor/RelationshipEditor.tsx

+// Bring in the CSS for glide-data-grid
+import "@glideapps/glide-data-grid/dist/index.css";


This was one of the changes with v6 of the lib.

tstirrat15 · 2025-10-09T23:37:11Z

src/spicedb-common/services/zedservice.ts

-  updatedRelationships: Relationship[] | undefined;
-  output: string | undefined;
-  error: string | undefined;
+  updatedSchema?: string;


?: is a terser way of expressing | undefined

tstirrat15 · 2025-10-09T23:37:53Z

.editorconfig

+[*.{ts,tsx}]
+indent_style = space
+indent_size = 2


For my own sanity

tstirrat15 · 2025-10-09T23:38:02Z

tsconfig.json

-    // TODO: get rid of this and fix the issues.
-    "noImplicitAny": false,


This was the motivating change.

tstirrat15 · 2025-10-17T18:49:02Z

src/spicedb-common/components/relationshipeditor/RelationshipEditor.tsx

    });
  };

-  const { drawCell, provideEditor } = useCustomCells(


This is one of the things that changed in v6 - you provide customRenderers directly instead of wrapping in drawCell and provideEditor.

tstirrat15 · 2025-10-17T19:45:21Z

src/playground-ui/debouncer.ts

  };

+  // TODO: this is creating a new `run` on every render. Refactor so that the reference is stable,
+  // or else use an off-the-shelf debounce.


Yeah, gonna treat this as a follow-on.

tstirrat15 · 2025-12-04T16:14:43Z

src/components/ValidationButton.tsx

 import Button from "@material-ui/core/Button";
 import { Theme, createStyles, makeStyles } from "@material-ui/core/styles";
-import { fade } from "@material-ui/core/styles/colorManipulator";
+import { alpha } from "@material-ui/core/styles/colorManipulator";


This was marking as deprecated; the names are aliases of each other.

tstirrat15 force-pushed the undisable-no-implicit-any branch from 43d0eb1 to d141dea Compare October 9, 2025 23:31

tstirrat15 marked this pull request as draft October 9, 2025 23:32

vercel bot deployed to Preview October 9, 2025 23:32 View deployment

tstirrat15 force-pushed the undisable-no-implicit-any branch from d141dea to fbff958 Compare October 9, 2025 23:32

vercel bot deployed to Preview October 9, 2025 23:33 View deployment

tstirrat15 force-pushed the undisable-no-implicit-any branch from fbff958 to 17101f6 Compare October 9, 2025 23:36

vercel bot deployed to Preview October 9, 2025 23:37 View deployment

tstirrat15 force-pushed the undisable-no-implicit-any branch 2 times, most recently from 137c384 to 05ea0c2 Compare October 17, 2025 18:46

tstirrat15 marked this pull request as ready for review October 17, 2025 18:47

vercel bot deployed to Preview October 17, 2025 18:47 View deployment

tstirrat15 force-pushed the undisable-no-implicit-any branch from 05ea0c2 to f075cf6 Compare October 17, 2025 19:38

vercel bot deployed to Preview October 17, 2025 19:38 View deployment

alecmerdler reviewed Oct 17, 2025

View reviewed changes

alecmerdler previously approved these changes Oct 17, 2025

View reviewed changes

tstirrat15 dismissed alecmerdler’s stale review via 4d3ebdd October 17, 2025 19:44

tstirrat15 force-pushed the undisable-no-implicit-any branch from f075cf6 to 4d3ebdd Compare October 17, 2025 19:44

vercel bot deployed to Preview October 17, 2025 19:45 View deployment

tstirrat15 commented Dec 4, 2025

View reviewed changes

tstirrat15 force-pushed the undisable-no-implicit-any branch from 4d3ebdd to 96277fb Compare December 4, 2025 16:00

vercel bot deployed to Preview December 4, 2025 16:02 View deployment

tstirrat15 added 8 commits December 4, 2025 09:13

Undisable no-implicit-any

c784197

Upgrade glide to get types

69aa4f3

Add editorconfig file to repo

2443779

Add dts file for visjs

774af47

Use new typescript command

37687f2

Fix a bunch of type issues

1339c9f

Get typechecks passing

d772c33

Fix bugs

c78e73f

Fix rendering of custom cells

f980c57

tstirrat15 force-pushed the undisable-no-implicit-any branch from 96277fb to f980c57 Compare December 4, 2025 16:13

vercel bot deployed to Preview December 4, 2025 16:14 View deployment

tstirrat15 commented Dec 4, 2025

View reviewed changes

alecmerdler approved these changes Dec 4, 2025

View reviewed changes

tstirrat15 merged commit cf36e05 into main Dec 4, 2025
5 checks passed

github-actions bot locked and limited conversation to collaborators Dec 4, 2025

		// TODO: this is creating a new `run` on every render. Refactor so that the reference is stable,
		// or else use an off-the-shelf debounce.

		@@ -0,0 +1,6 @@
		declare module "visjs-network" {
		// TODO: go reverse-engineer these types

		// Bring in the CSS for glide-data-grid
		import "@glideapps/glide-data-grid/dist/index.css";

		// TODO: get rid of this and fix the issues.
		"noImplicitAny": false,

Undisable noImplicitAny #84

Undisable noImplicitAny #84

Uh oh!

Conversation

tstirrat15 commented Oct 9, 2025

Description

Changes

Testing

Uh oh!

vercel bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alecmerdler left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Undisable `noImplicitAny` #84

Undisable `noImplicitAny` #84

vercel bot commented Oct 9, 2025 •

edited

Loading