feat(webauthn): support MFA-session passkey registration#47
Open
lakhansamani wants to merge 1 commit into
Open
feat(webauthn): support MFA-session passkey registration#47lakhansamani wants to merge 1 commit into
lakhansamani wants to merge 1 commit into
Conversation
webauthn_registration_options/verify required a bearer token, unavailable during a token-withheld MFA offer. Add email/phone_number/ state so registerPasskey can authenticate via the MFA session cookie instead, and return the full AuthResponse (access_token on success) rather than a bare message. Also add mfa_gate to parseMfaRedirectParams so callers can tell an enrollment offer from a challenge for an already-configured factor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webauthn_registration_options/webauthn_registration_verifycan now authenticate via the MFA session cookie (email/phone_number/state), not just a bearer token — needed so a passkey can be registered during a token-withheld MFA offer, before any token exists.webauthnRegistrationVerify/registerPasskeynow return the fullAuthTokenshape (access_token populated when this call completed the withheld MFA gate) instead of a bare message.parseMfaRedirectParamsgainsmfaGate: 'offer' | 'verify'so a host app can tell a first-time enrollment offer from a challenge for an already-configured factor.Backend counterpart: authorizerdev/authorizer#<branch feat/enforce-mfa-passkey-gate>.
Test plan
npx jest __test__/webauthnMethods.test.ts __test__/mfaRedirect.test.ts— all passing, new cases addednpm run build— cleannpx tsc --noEmit(consumer side, via authorizer-react) — clean